All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@redhat.com>
Cc: Manish Lachwani <manish@Zambeel.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] tg3 intr masking update
Date: Sat, 21 Dec 2002 15:38:08 -0500	[thread overview]
Message-ID: <3E04D130.8040504@pobox.com> (raw)
In-Reply-To: <3E04CFBE.2060909@pobox.com>

Additional note about this change,

The NAPI docs mention specific areas where races may occur, and 
coincedentally so do the tg3 docs.  The tg3 docs suggest to me that in 
tg3_poll, after we unmask ints, we should
* flush the MMIO write
* check the status block for updates again
* tell tg3 to deliver to us an artificial interrupt just in case we 
raced [IMO preferred versus simply returning 'not-done' in tg3_poll retval]

But this is just a theory and not tested yet...

      reply	other threads:[~2002-12-21 20:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-21 20:31 [PATCH] tg3 intr masking update Jeff Garzik
2002-12-21 20:38 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E04D130.8040504@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@redhat.com \
    --cc=manish@Zambeel.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.