From: Douglas Gilbert <dougg@torque.net>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] scsi_reset_provider() in scsi_error.c lk2.5.52
Date: Tue, 24 Dec 2002 10:34:10 +1100 [thread overview]
Message-ID: <3E079D72.1010909@torque.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
While testing Willem's last ide-scsi "rev1" patch
with sg_reset I found that scsi_reset_provider()
attempts to delete a timer that has not been set.
A crude patch is attached that stops the kernel noise.
Hopefully James can improve on it.
Doug Gilbert
[-- Attachment #2: scsi_error_2552_reset.diff --]
[-- Type: text/plain, Size: 426 bytes --]
--- linux/drivers/scsi/scsi_error.c 2002-12-22 16:19:53.000000000 +1100
+++ linux/drivers/scsi/scsi_error.c2552res 2002-12-24 10:16:32.000000000 +1100
@@ -1811,6 +1811,10 @@
*/
SCpnt->pid = 0;
+ /* Code expects a timer to be set, so set one for 120 seconds */
+ init_timer(&SCpnt->eh_timeout);
+ scsi_add_timer(SCpnt, 120 * HZ, scsi_eh_times_out);
+
rtn = scsi_new_reset(SCpnt, flag);
scsi_delete_timer(SCpnt);
reply other threads:[~2002-12-23 23:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E079D72.1010909@torque.net \
--to=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.