From: Douglas Gilbert <dougg@torque.net>
To: linux-scsi@vger.kernel.org
Cc: wrlk@riede.org
Subject: [PATCH] lk2.5.53 ide-scsi
Date: Tue, 24 Dec 2002 20:03:55 +1100 [thread overview]
Message-ID: <3E0822FB.4070001@torque.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
Willem's main ide-scsi patch got into lk 2.5.53 but not
his rev1.patch (oops on reset). It is re-packaged as the
ide-scsi_2553wr2.diff attachment. His patch to cleanly
unregister sysfs entries didn't make it into
drivers/ide/ide.c so it is attached as well.
Doug Gilbert
[-- Attachment #2: ide-scsi_2553wr2.diff --]
[-- Type: text/plain, Size: 997 bytes --]
--- linux/drivers/scsi/ide-scsi.c 2002-12-24 18:12:54.000000000 +1100
+++ linux/drivers/scsi/ide-scsi.c2553wr2 2002-12-24 09:30:17.000000000 +1100
@@ -289,6 +289,7 @@
pc->timeout = jiffies + WAIT_READY;
/* NOTE! Save the failed packet command in "rq->buffer" */
rq->buffer = (void *) failed_command->special;
+ pc->scsi_cmd = ((idescsi_pc_t *) failed_command->special)->scsi_cmd;
if (test_bit(IDESCSI_LOG_CMD, &scsi->log)) {
printk ("ide-scsi: %s: queue cmd = ", drive->name);
hexdump(pc->c, 6);
@@ -876,7 +877,8 @@
/* is cmd active?
* need to lock so this stuff doesn't change under us */
spin_lock_irqsave(&ide_lock, flags);
- if (scsi->pc && scsi->pc->scsi_cmd->serial_number == cmd->serial_number) {
+ if (scsi->pc && scsi->pc->scsi_cmd &&
+ scsi->pc->scsi_cmd->serial_number == cmd->serial_number) {
/* yep - let's give it some more time -
* we can do that, we're in _our_ error kernel thread */
spin_unlock_irqrestore(&ide_lock, flags);
[-- Attachment #3: ide_2552_wr1.diff --]
[-- Type: text/plain, Size: 319 bytes --]
--- linux/drivers/ide/ide.c 2002-12-10 17:38:28.000000000 +1100
+++ linux/drivers/ide/ide.c2552willem 2002-12-24 09:10:25.000000000 +1100
@@ -2314,6 +2314,8 @@
{
ide_drive_t *drive;
+ driver_unregister(&driver->gen_driver);
+
spin_lock(&drivers_lock);
list_del(&driver->drivers);
spin_unlock(&drivers_lock);
reply other threads:[~2002-12-24 9:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E0822FB.4070001@torque.net \
--to=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=wrlk@riede.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.