All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Brad Hards <bhards@bigpond.net.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Deprecate exec_usermodehelper, fix request_module.
Date: Thu, 02 Jan 2003 23:36:57 -0800	[thread overview]
Message-ID: <3E153D99.58D95C0F@digeo.com> (raw)
In-Reply-To: 200301031722.03325.bhards@bigpond.net.au

Brad Hards wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Fri, 3 Jan 2003 16:08, Rusty Russell wrote:
> > + * Must be called from process context.  Returns a negative error code
> > + * if program was not execed successfully, or (exitcode << 8 + signal)
> > + * of the application (0 if wait is not set).
> Any chance that you can remove this (existing) restriction. It'd be good to be
> able to use this in some networking code (eg netif_carrier_[off|on]() ), but
> that might be in interrupt context.
> 
> It may be just a matter of duplicating the arguments, but I really know SFA
> about this stuff, and am loath to touch it least it turn to mush in my
> fingers.
> 

I vaguely seem to recall having done that once.

It wasn't very pretty:

	int gfp_flags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL; 

Patch against 2.4.0-test13 is at http://www.zip.com.au/~akpm/linux/1.txt

      parent reply	other threads:[~2003-01-03  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02  9:36 [PATCH] Deprecate exec_usermodehelper, fix request_module Rusty Russell
2003-01-02 17:14 ` Marcel Holtmann
2003-01-02 19:08   ` Thomas Sailer
2003-01-03  5:08     ` Rusty Russell
2003-01-03  6:21       ` Brad Hards
2003-01-03  7:25         ` Jeff Garzik
2003-01-03  7:36         ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E153D99.58D95C0F@digeo.com \
    --to=akpm@digeo.com \
    --cc=bhards@bigpond.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.