All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Costa Tsaousis <costa@tsaousis.gr>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH]: fix all iptables problems with '!' (hopefully)
Date: Mon, 06 Jan 2003 16:33:44 +0100	[thread overview]
Message-ID: <3E19A1D8.7080605@trash.net> (raw)
In-Reply-To: <36373.195.97.5.193.1041856153.squirrel@fs.tsaousis.gr>

Costa Tsaousis wrote:

>Patrick McHardy said:
>  
>
>>I did, here is the (untested) patch, hopefully i didn't miss any.
>>I didn't change any of the "save"-functions, this patch just replaces
>>all uses
>>of optarg after check_inverse by argv[optind-1].
>>    
>>
>
>I didn't test it, but keep in mind that the ! in certain cases has to be
>placed *before* the argument and its value.
>
>For example:
>
>--uid-owner ! squid
>
>is not accepted either ("user '!' not found"). The correct is:
>
>! --uid-owner squid
>  
>
In fact ! is used in many matches in a non-boolean context.
After the patch is applied, both it always possible
(! --uid-owner xxx / --uid-owner ! xxx).
It would still be nice to have the helptexts unified concerning
the use of '!', i think.

Regards,
Patrick

  reply	other threads:[~2003-01-06 15:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-06  1:31 iptables-save saves invalid negative --uid-owner expressions Costa Tsaousis
2003-01-06  2:02 ` Hervé Eychenne
2003-01-06  8:07   ` Bart De Schuymer
2003-01-06  8:15   ` [PATCH]: fix all iptables problems with "!" (hopefully) Patrick McHardy
2003-01-06 12:29     ` [PATCH]: fix all iptables problems with '!' (hopefully) Costa Tsaousis
2003-01-06 15:33       ` Patrick McHardy [this message]
2003-01-07 17:15         ` Harald Welte
2003-01-07 18:53           ` Patrick McHardy
2003-01-07 20:16             ` Harald Welte
2003-01-08 18:37               ` Patrick McHardy
2003-01-06 12:34   ` iptables-save saves invalid negative --uid-owner expressions Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E19A1D8.7080605@trash.net \
    --to=kaber@trash.net \
    --cc=costa@tsaousis.gr \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.