All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roberto Nibali <ratz@tac.ch>
To: Don Cohen <don-nf@isis.cs3-inc.com>
Cc: ", Harald Welte" <laforge@gnumonks.org>,
	netfilter-devel@lists.netfilter.org
Subject: Re: iptables u32 match code for review/testing/...
Date: Wed, 08 Jan 2003 11:31:53 +0100	[thread overview]
Message-ID: <3E1BFE19.9020509@tac.ch> (raw)
In-Reply-To: 15899.51201.381520.438520@isis.cs3-inc.com

>  > I like the content (code/implementation/idea of having u32).
>  > The only issue is that it doesn't really fit into the current iptables
>  > architecture. Why?
>  > 	- because it is a whole classification engine on it's own
> Why is this bad?  I wrote it to do things I wanted to do but didn't
> see how.  I think that's good.  If it subsumes a few others that are
> out there, even better.  (But it's almost certainly a lot slower than 
> any more specialized match, so they're still useful.)

What's wrong with: http://www.cyberus.ca/~hadi/patches/action/ ?
Why couldn't you use some of its code for the classification engine?

> But if you do want wide indentation (and don't mind >80 cols)
> then here you go:

Looks a lot nicer and ledgible to me but I'm not the one in position to 
criticise coding style.

Best regards,
Roberto Nibali, ratz
-- 
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc

  reply	other threads:[~2003-01-08 10:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-27 18:54 iptables u32 match code for review/testing/ Don Cohen
2003-01-06 12:57 ` Harald Welte
2003-01-06 17:04   ` Don Cohen
2003-01-07 18:57     ` Harald Welte
2003-01-08  6:41       ` Don Cohen
2003-01-08 10:31         ` Roberto Nibali [this message]
2003-01-08 10:56         ` Harald Welte
2003-01-08 19:53           ` Don Cohen
2003-01-08 21:16             ` Harald Welte
2003-01-08 22:10           ` iptables u32 match patch-o-matic (attempt) Don Cohen
2003-01-11 19:47             ` Harald Welte
2003-01-12 21:11               ` Don Cohen
2003-01-25 18:39                 ` Harald Welte
2003-01-07 18:53 ` iptables u32 match code for review/testing/ Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E1BFE19.9020509@tac.ch \
    --to=ratz@tac.ch \
    --cc=don-nf@isis.cs3-inc.com \
    --cc=laforge@gnumonks.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.