All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Fugmann <afu@fugmann.dhs.org>
To: Harald Welte <laforge@gnumonks.org>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: Fixed proken MARK target in POM.
Date: Fri, 10 Jan 2003 17:38:42 +0100	[thread overview]
Message-ID: <3E1EF712.8000100@fugmann.dhs.org> (raw)
In-Reply-To: <3E1EE68C.7030004@fugmann.dhs.org>

Anders Fugmann wrote:
> Harald Welte wrote:
> 
>> On Thu, Jan 09, 2003 at 02:07:37PM +0100, Anders Fugmann wrote:
>>
>>
>>> The patch maintains backward compability, and I request that this 
>>> patch is applied to mainstream (and pushed to the Andrea for kernel 
>>> inclusion), 
>>
>>
>>
>> 1) Where is the compatibility?  I cannot see how this code change would
>>    ensure that
>>     a) old, unpatched kernel works with new, patched userspace
>>     b) new, patched kernel works with old, unpatched userspace
>>    Those two conditions need to be fulfilled, otherwise we cannot make a
>>    change during the stable kernel series.
Looking at bit further, this seems non-trivial as I guess that the 
userspace should compile no matter kernel-headers version - no?

Are defines tolerated? Something like:
#define MARK_BITOPS

and then in the userspace do a:
#ifdef MARK_BITOPS
Whenever the new fileds in the structure is used.

But IMHO this clutters the code up and I would rather avoid that.
Do you know of modules that had the same problem, or do you regard it as 
unresolvable to add an extra field to a structure in the stable series?

Regards
Anders Fugmann

  reply	other threads:[~2003-01-10 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-09 13:07 Fixed proken MARK target in POM Anders Fugmann
2003-01-10 14:00 ` Harald Welte
2003-01-10 15:28   ` Anders Fugmann
2003-01-10 16:38     ` Anders Fugmann [this message]
2003-01-11 19:16       ` Harald Welte
2003-01-12 19:58         ` Anders Fugmann
2003-01-11 19:23     ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E1EF712.8000100@fugmann.dhs.org \
    --to=afu@fugmann.dhs.org \
    --cc=laforge@gnumonks.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.