From: Manfred Spraul <manfred@colorfullife.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
Maciej Soltysiak <solt@dns.toxicfilms.tv>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [PATCH]Re: spin_locks without smp.
Date: Fri, 10 Jan 2003 18:19:55 +0100 [thread overview]
Message-ID: <3E1F00BB.2090904@colorfullife.com> (raw)
Alan wrote:
>On Fri, 2003-01-10 at 13:04, William Lee Irwin III wrote:
>> Okay, what I'm getting here is that the UP case already has preempt
>> disabled b/c the locks are taken in IRQ context?
>
>The tx/timeout path isnt always in IRQ context.
>
It is.
tx and timeout are both called at BH context with the dev_xmit spinlock
held. See Documentation/networking/netdevices.txt
What about
disable_irq();
spin_lock(&np->lock);
That's what 8390.c uses, no need for an #ifdef.
--
Manfred
next reply other threads:[~2003-01-10 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 17:19 Manfred Spraul [this message]
2003-01-10 18:18 ` [PATCH]Re: spin_locks without smp Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2003-01-11 13:22 Mikael Pettersson
2003-01-11 14:29 ` Alan Cox
2003-01-10 11:42 Maciej Soltysiak
2003-01-10 11:45 ` William Lee Irwin III
2003-01-10 11:48 ` William Lee Irwin III
2003-01-10 12:09 ` [PATCH]Re: " Maciej Soltysiak
2003-01-10 13:20 ` Alan Cox
2003-01-10 13:04 ` William Lee Irwin III
2003-01-10 14:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E1F00BB.2090904@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=solt@dns.toxicfilms.tv \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.