[PATCH]: PPP_FILTER outbound only drops with debugging enables

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hi.

Packets in ppp_send_frame catched by pass_filter are only dropped if 
debuging is enabled:

                if (ppp->pass_filter.filter
                    && sk_run_filter(skb, ppp->pass_filter.filter,
                                     ppp->pass_filter.len) == 0) {
                        if (ppp->debug & 1) {
                                printk(KERN_DEBUG "PPP: outbound frame 
not passed\n");
                                kfree_skb(skb);
                                return;
                        }
                }



The problem is still present in 2.5 bitkeeper tree. Attached patch fixes it.
Regards,
Patrick


[-- Attachment #2: ppp_filter-outbound-fix.diff --]
[-- Type: text/plain, Size: 598 bytes --]

--- linux-2.4.20/drivers/net/ppp_generic.c.orig	2003-01-17 13:15:32.000000000 +0100
+++ linux-2.4.20/drivers/net/ppp_generic.c	2003-01-17 13:16:23.000000000 +0100
@@ -965,11 +965,10 @@
 		if (ppp->pass_filter.filter
 		    && sk_run_filter(skb, ppp->pass_filter.filter,
 				     ppp->pass_filter.len) == 0) {
-			if (ppp->debug & 1) {
+			if (ppp->debug & 1)
 				printk(KERN_DEBUG "PPP: outbound frame not passed\n");
-				kfree_skb(skb);
-				return;
-			}
+			kfree_skb(skb);
+			return;
 		}
 		/* if this packet passes the active filter, record the time */
 		if (!(ppp->active_filter.filter