All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] HT scheduler, sched-2.5.59-D7
Date: Mon, 20 Jan 2003 22:59:26 +0100	[thread overview]
Message-ID: <3E2C713E.2050301@colorfullife.com> (raw)

Ingo wrote:

>--- linux/fs/pipe.c.orig	2003-01-20 19:28:43.000000000 +0100
>+++ linux/fs/pipe.c	2003-01-20 22:58:35.000000000 +0100
>@@ -117,7 +117,7 @@
> 	up(PIPE_SEM(*inode));
> 	/* Signal writers asynchronously that there is more room.  */
> 	if (do_wakeup) {
>-		wake_up_interruptible(PIPE_WAIT(*inode));
>+		wake_up_interruptible_sync(PIPE_WAIT(*inode));
> 		kill_fasync(PIPE_FASYNC_WRITERS(*inode), SIGIO, POLL_OUT);
> 	}
> 	if (ret > 0)
>
What's the purpose of this change?
I thought that the _sync functions should be called if it's guaranteed 
that schedule() will be called immediately, i.e. if the scheduler should 
not rebalance.
You've added _sync() to the codepaths that lead to the end of the syscall.

--
    Manfred


             reply	other threads:[~2003-01-20 21:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-20 21:59 Manfred Spraul [this message]
2003-01-20 22:16 ` [patch] HT scheduler, sched-2.5.59-D7 Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2003-01-20 19:52 [patch] sched-2.5.59-A2 Martin J. Bligh
2003-01-20 21:18 ` [patch] HT scheduler, sched-2.5.59-D7 Ingo Molnar
2003-01-20 22:28   ` Andrew Morton
2003-01-21  1:11     ` Michael Hohnbaum
2003-01-22  3:15   ` Michael Hohnbaum
2003-01-22 16:41     ` Andrew Theurer
2003-01-22 16:17       ` Martin J. Bligh
2003-01-22 16:20         ` Andrew Theurer
2003-01-22 16:35       ` Michael Hohnbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E2C713E.2050301@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.