From: Patrick McHardy <kaber@trash.net>
To: Laszlo Valko <valko@linux.karinthy.hu>
Cc: Don Cohen <don-netf@isis.cs3-inc.com>,
netfilter-devel@lists.netfilter.org
Subject: [OT Re: Question: Variable sized matchinfo
Date: Tue, 21 Jan 2003 17:32:46 +0100 [thread overview]
Message-ID: <3E2D762E.1040001@trash.net> (raw)
In-Reply-To: <20030121170702.B24205@linux.karinthy.hu>
Laszlo Valko wrote:
>On Tue, Jan 21, 2003 at 12:42:16PM +0100, Patrick McHardy wrote:
>
>
>>Oops, i probably missed that.
>>Anyway this doesn't seem to be real problem, you could just pass pointers
>>and copy_from_user the data. The probleme there is the match is not informed
>>if its not needed anymore, so no chance to free the memory.
>>
>>
>
>But consider that the pointer on the kernel-side might not look like
>what it looks like on the user-side!
>
>See my patch earlier with a sparc64 compatibility fix. Basically,
>you will have to implement a thunk which translates the 32-bit userspace
>pointer sent from iptables to a 64-bit kernelspace pointer. The best
>solution is to avoid pointers, as the pointer translation usually involves
>translating the whole struct being passed because of the field
>offset differences.
>
>Laszlo
>
>
you're right of course .. one question: i see copy_from_user in many
places in the kernel, often within with user supplied
addresses. Do all of these don't work on sparc64 ? what a horrible
architecture ;)
regards,
patrick
next prev parent reply other threads:[~2003-01-21 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030120232634.24011.21218.Mailman@kashyyyk>
2003-01-21 6:19 ` conntrack hash function comparison Don Cohen
2003-01-21 11:12 ` Jozsef Kadlecsik
2003-01-21 16:59 ` Don Cohen
2003-01-31 11:41 ` Harald Welte
2003-02-01 0:41 ` Don Cohen
2003-02-01 6:57 ` Patrick Schaaf
2003-02-01 7:58 ` Don Cohen
2003-02-01 8:37 ` Harald Welte
2003-02-01 19:05 ` Don Cohen
2003-02-02 22:45 ` Harald Welte
2003-01-21 6:40 ` Question: Variable sized matchinfo Don Cohen
2003-01-21 11:42 ` Patrick McHardy
2003-01-21 16:07 ` Laszlo Valko
2003-01-21 16:32 ` Patrick McHardy [this message]
2003-01-21 16:46 ` [OT " Laszlo Valko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E2D762E.1040001@trash.net \
--to=kaber@trash.net \
--cc=don-netf@isis.cs3-inc.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=valko@linux.karinthy.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.