From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@redhat.com>
Cc: ink@jurassic.park.msu.ru, Jeff.Wiedemeier@hp.com,
willy@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state
Date: Fri, 24 Jan 2003 17:51:22 -0500 [thread overview]
Message-ID: <3E31C36A.7040000@pobox.com> (raw)
In-Reply-To: <20030124.143252.97527503.davem@redhat.com>
David S. Miller wrote:
> From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Date: Sat, 25 Jan 2003 01:41:02 +0300
>
> I don't understand the issue, really. The config register says:
> "MSIs are enabled". Which means: "My platform is *really* going to
> use MSI". Why do you want to ignore that?
Let us define "platform." If you mean ia32 or alpha or sparc64, yes
this is a quirk. If you mean tg3, no, this is not a quirk.
> I see, why not code up a generic pci_using_msi(pdev) that
> does this?
Great minds think alike :) This was going to be my suggestion:
call pci_using_msi(pdev), and require that it be called before
pci_enable_device().
This fits Jeff's "disabling MSI at config time" AFAICS...
Jeff
next prev parent reply other threads:[~2003-01-24 22:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-24 18:27 [patch 2.5] tg3.c: pci_{save,restore}_extended_state Ivan Kokshaysky
2003-01-24 19:31 ` Jeff Garzik
2003-01-24 19:34 ` David S. Miller
2003-01-24 20:00 ` Wiedemeier, Jeff
2003-01-24 19:53 ` David S. Miller
2003-01-24 20:04 ` Wiedemeier, Jeff
2003-01-24 20:05 ` Jeff Garzik
2003-01-24 20:24 ` Wiedemeier, Jeff
2003-01-24 20:34 ` Jeff Garzik
2003-01-24 20:46 ` Wiedemeier, Jeff
2003-01-24 20:51 ` David S. Miller
2003-01-24 21:33 ` Wiedemeier, Jeff
2003-01-24 21:34 ` David S. Miller
2003-01-24 22:41 ` Ivan Kokshaysky
2003-01-24 22:32 ` David S. Miller
2003-01-24 22:51 ` Jeff Garzik [this message]
2003-01-25 0:33 ` Wiedemeier, Jeff
2003-01-25 1:42 ` David S. Miller
2003-01-24 22:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E31C36A.7040000@pobox.com \
--to=jgarzik@pobox.com \
--cc=Jeff.Wiedemeier@hp.com \
--cc=davem@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.