From: Ross Biro <rossb@google.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: BUG: [2.4.18+] IDE Race Condition
Date: Thu, 30 Jan 2003 08:58:50 -0800 [thread overview]
Message-ID: <3E3959CA.5040907@google.com> (raw)
In-Reply-To: 1043948091.31674.8.camel@irongate.swansea.linux.org.uk
Alan Cox wrote:
>>st should be replaced with
>>if (!masked_irq || hwif->irq != masked_irq)
>>in two places.
>>
>>
>
>Which would also shorten to if (hwif->irq != masked_irq) it seems
>
>
>
With the assumption that hwif->irq != 0 which is implicit now. Perhaps
we should make the assumption explicit,
if (unlikely(hwif->irq == 0)) {
BUG();
}
if (hwif->irq != masked_irq) ....
Ross
next prev parent reply other threads:[~2003-01-30 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-27 17:11 BUG: [2.4.18+] IDE Race Condition Ross Biro
2003-01-27 17:34 ` Ross Biro
2003-01-28 2:46 ` Andre Hedrick
2003-01-28 16:48 ` Ross Biro
2003-01-28 17:28 ` Andre Hedrick
2003-01-28 17:42 ` Ross Biro
2003-01-28 18:01 ` Andre Hedrick
2003-01-30 17:34 ` Alan Cox
2003-01-30 16:58 ` Ross Biro [this message]
2003-01-30 18:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E3959CA.5040907@google.com \
--to=rossb@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.