From: Philip Craig <philipc@snapgear.com>
To: Harald Welte <laforge@netfilter.org>
Cc: Paul Mielke <paulm@routefree.com>, netfilter-devel@lists.netfilter.org
Subject: Re: PPTP connection tracking
Date: Wed, 19 Feb 2003 09:57:19 +1000 [thread overview]
Message-ID: <3E52C85F.40800@snapgear.com> (raw)
In-Reply-To: 20030218093812.GM11812@sunbeam.de.gnumonks.org
Harald Welte wrote:
> On Tue, Feb 18, 2003 at 10:50:51AM +1000, Philip Craig wrote:
>
>>>Can you please test if your setup works with this patch?
>>
>>Paul and I have tested that the attached patch fixes the problem.
>>It is similar to yours, except that it returns earlier. I don't
>>think the calls to place_in_hashes() and do_bindings() are
>>necessary if we just need to return NF_ACCEPT without doing any
>>NAT?
>
>
> yes, but I can imagine the case where somebody actually _does_ want to
> do some nat from the expectfn() - and we should keep that option open...
That is exactly the problem this patch is solving. We want
to do NAT in expectfn() for PPTP, but the #ifdef for local NAT
was too early and expectfn() wasn't being called at all. So this
patch moves the #ifdef into a code path that isn't followed if
expectfn() needs to be called.
--
Philip Craig - philipc@snapgear.com - http://www.SnapGear.com
SnapGear - Custom Embedded Solutions and Security Appliances
next prev parent reply other threads:[~2003-02-18 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-19 23:01 PPTP connection tracking Paul Mielke
2003-02-17 19:00 ` Harald Welte
2003-02-18 0:50 ` Philip Craig
2003-02-18 9:38 ` Harald Welte
2003-02-18 23:57 ` Philip Craig [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-03 2:49 Ilguiz Latypov
2002-12-03 3:02 ` Ilguiz Latypov
2002-12-03 3:31 ` Philip Craig
2002-12-03 3:29 ` Philip Craig
2002-11-29 7:58 Philip Craig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E52C85F.40800@snapgear.com \
--to=philipc@snapgear.com \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=paulm@routefree.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.