All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrique Gobbi <henrique2.gobbi@cyclades.com>
To: linux-kernel@vger.kernel.org
Subject: n_tty.c - possible enhancement
Date: Tue, 25 Feb 2003 16:47:31 +0000	[thread overview]
Message-ID: <3E5B9E23.6080303@cyclades.com> (raw)
In-Reply-To: 3E2CF0A1.5030203@ToughGuy.net

Dear all !!!

I was having data loss problems using my serial ports at 115200 with 
software flow control (I can't use hw flow control) and I ended up 
figuring out that the problem was happening because of the small value 
of the tty buffer high water mark (TTY_THRESHOLD_THROTTLE). Changing 
that define value and recompiling the kernel was the only solution i 
found to my problem.

The way this code is implemented today is bad. The water marks are hard 
coded and the only way to change them is recompiling the kernel again, 
and this is not a good solution for that. I want to change that.

My idea is:
-------------------------------------------------------------------------
1 - Create two new variables in the tty struct: high_watermark and 
low_watermark;

2 - Initialize this variables with the values they have today: 128 and 128;

3 - Create 4 ioctl's to set and get the values of this 2 variables;

4 - Change the file n_tty.c. The line that has
	if (n_tty_receive_room(tty) < TTY_THRESHOLD_THROTTLE) {
     will have:
	if (n_tty_receive_room(tty) < tty->high_watermark) {

     and the same thing will be done for the low watermark
-------------------------------------------------------------------------

I would appreciate any comment on this matter. If you guys don't see any 
problem on this I will commit a patch as soon as possible

later
Henrique


  reply	other threads:[~2003-02-26  0:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-21  6:17 Kernel debugger Madhavi
2003-01-21  7:02 ` Linux Geek
2003-02-25 16:47   ` Henrique Gobbi [this message]
2003-02-27 10:34     ` n_tty.c - possible enhancement Sergei Organov
2003-02-25 17:14   ` Preemptive kernel Henrique Gobbi
2003-02-26  1:30     ` Robert Love
2003-01-22 18:06 ` Kernel debugger Richard J Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E5B9E23.6080303@cyclades.com \
    --to=henrique2.gobbi@cyclades.com \
    --cc=henrique.gobbi@cyclades.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.