From: Jeff Garzik <jgarzik@pobox.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix warning in drivers/net/sis900.c
Date: Sat, 01 Mar 2003 12:23:09 -0500 [thread overview]
Message-ID: <3E60EC7D.2040802@pobox.com> (raw)
In-Reply-To: <51890000.1046538667@[10.10.2.4]>
Martin J. Bligh wrote:
> drivers/net/sis900.c: In function `set_rx_mode':
> drivers/net/sis900.c:2100: warning: passing arg 2 of `set_bit' from incompatible pointer type
>
> I just cast this. Seems to work fine at the moment, so presumably it's
> correct.
Nope -- set_bit wants to work on a real unsigned long. While your patch
will work, the proper fix is to not use set_bit :)
Jeff
next prev parent reply other threads:[~2003-03-01 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-01 17:11 [PATCH] fix warning in drivers/net/sis900.c Martin J. Bligh
2003-03-01 17:23 ` Jeff Garzik [this message]
2003-03-20 7:34 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E60EC7D.2040802@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.