From: "Kevin P. Fleming" <kpfleming@cox.net>
To: Paul Clements <Paul.Clements@SteelEye.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] convert md to use seq_file for /proc/mdstat
Date: Thu, 06 Mar 2003 08:08:00 -0700 [thread overview]
Message-ID: <3E676450.60805@cox.net> (raw)
In-Reply-To: <3E6701E8.71C11255@SteelEye.com>
Paul Clements wrote:
> Hi Kevin,
>
> I like the patch. I'm just curious...why'd you axe the CONFIG_PROC_FS
> ifdef's ?
>
> --
> Paul
>
>
>
>>-#ifdef CONFIG_PROC_FS
>>- create_proc_read_entry("mdstat", 0, NULL, md_status_read_proc, NULL);
>>-#endif
>
>
>
>>-#ifdef CONFIG_PROC_FS
>> remove_proc_entry("mdstat", NULL);
>>-#endif
Two reasons, really:
- constant harping on LKML about how everyone hates #ifdefs <G>
- <linux/proc_fs.h> provides "return NULL" inline versions of these
functions if CONFIG_PROC_FS is not defined, so presumably the compiler
will just compile them away in that situation
prev parent reply other threads:[~2003-03-06 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-06 6:22 [PATCH] convert md to use seq_file for /proc/mdstat Kevin P. Fleming
2003-03-06 8:08 ` Paul Clements
2003-03-06 15:08 ` Kevin P. Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E676450.60805@cox.net \
--to=kpfleming@cox.net \
--cc=Paul.Clements@SteelEye.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.