From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 3/3] add Via Nehemiah ("xstore") rng support
Date: Tue, 11 Mar 2003 21:19:07 -0800 [thread overview]
Message-ID: <3E6EC34B.2000605@zytor.com> (raw)
In-Reply-To: <3E6EC2AD.7000504@pobox.com>
Jeff Garzik wrote:
>>
>> Note that your "=m" (*addr) is never actually used here -- it doesn't
>> affect the instruction encoding, and it only shows up in a comment.
>> Since gcc will generate an instruction mode here, it will be highly
>> confused.
>>
>> I am assuming 0xC0 is a modr/m byte, in which case the most sane
>> interpretation of this instruction would be "xstore %eax"; %edi is
>> presumably implicit since you claim it can take a REP prefix...
>
>
> and yet strangely the asm code seems to be correct :)
>
Right... I got confused by the comment (the one inside the asm) and the
fact that "addr" appeared twice. I think it's a bad comment; it draws
attention to the wrong thing.
-hpa
next prev parent reply other threads:[~2003-03-12 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200303120427.UAA00323@cesium.transmeta.com>
2003-03-12 5:16 ` [patch 3/3] add Via Nehemiah ("xstore") rng support Jeff Garzik
2003-03-12 5:19 ` H. Peter Anvin [this message]
2003-03-12 3:27 Jeff Garzik
2003-03-12 3:31 ` Jeff Garzik
2003-03-12 12:55 ` Dave Jones
2003-03-12 15:16 ` Linus Torvalds
2003-03-12 16:21 ` H. Peter Anvin
2003-03-12 17:56 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E6EC34B.2000605@zytor.com \
--to=hpa@zytor.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.