From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: usb-devel <linux-usb-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Jeff Garzik <jgarzik@pobox.com>
Subject: [patch 2.5.65] ehci-hcd, don't use PCI MWI
Date: Wed, 19 Mar 2003 07:21:42 -0800 [thread overview]
Message-ID: <3E788B06.4090302@pacbell.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
Hi,
Some users have been sending init logs for Athlon kernels that
include PCI warning messages about the PCI cache line size
getting set incorrectly ... where the kernel thinks that the
right value is 16 bytes. Since 64 bytes is the right number,
it's dangerous to enable MWI on such systems.
This patch stops trying to use MWI; it's a workaround for the
misbehavior of that PCI cacheline-setting code. Please apply
to 2.5 and 2.4 trees.
- Dave
[-- Attachment #2: ehci-0319a.patch --]
[-- Type: text/plain, Size: 543 bytes --]
--- 1.45/drivers/usb/host/ehci-hcd.c Mon Feb 24 03:30:38 2003
+++ edited/drivers/usb/host/ehci-hcd.c Wed Mar 19 07:05:33 2003
@@ -432,7 +432,11 @@
}
/* help hc dma work well with cachelines */
- pci_set_mwi (ehci->hcd.pdev);
+ /* NOTE: disabled until it works reliably ... some x86/Athlon
+ * kernels are thinking 16 byte cachelines, not 64 byte ones,
+ * so clearly the MWI prep logic is wrong.
+ */
+ // pci_set_mwi (ehci->hcd.pdev);
/* clear interrupt enables, set irq latency */
temp = readl (&ehci->regs->command) & 0xff;
next reply other threads:[~2003-03-19 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-19 15:21 David Brownell [this message]
2003-03-19 15:34 ` [patch 2.5.65] ehci-hcd, don't use PCI MWI Jeff Garzik
2003-03-19 15:53 ` David Brownell
2003-03-19 16:34 ` Ivan Kokshaysky
2003-03-19 18:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E788B06.4090302@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.