From: Luben Tuikov <luben@splentec.com>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Jens Axboe <axboe@suse.de>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.5.x use list_head to handle scsi starved request queues
Date: Mon, 24 Mar 2003 17:15:26 -0500 [thread overview]
Message-ID: <3E7F837E.9020900@splentec.com> (raw)
In-Reply-To: 20030324135640.A12273@beaverton.ibm.com
Patrick Mansfield wrote:
>
> The current code in scsi_queue_next_request() assume queue_lock ==
> host_lock, as does code in scsi_error.c. We get a queue_lock (or
> host_lock), and then iterate over different q's calling
> __blk_run_queue(q).
1. Please don't speak of queue_lock and host_lock as if they are
the same thing. They are NOT, even though one points to the other.
This is an infrastructure bug and will have to go.
2. Yes I see this in scsi_error.c. How did this ever slip in!
(yes this is NOT a question, but a statement)
--
Luben
next prev parent reply other threads:[~2003-03-24 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 2:27 [PATCH] 2.5.x use list_head to handle scsi starved request queues Patrick Mansfield
2003-03-20 20:05 ` Luben Tuikov
2003-03-21 4:39 ` Patrick Mansfield
2003-03-21 20:48 ` Luben Tuikov
2003-03-22 0:50 ` Patrick Mansfield
2003-03-24 17:12 ` Luben Tuikov
2003-03-24 19:29 ` Patrick Mansfield
2003-03-24 20:20 ` Luben Tuikov
2003-03-24 20:25 ` Jens Axboe
2003-03-24 20:38 ` Patrick Mansfield
2003-03-24 21:25 ` Luben Tuikov
2003-03-24 21:56 ` Patrick Mansfield
2003-03-24 22:15 ` Luben Tuikov [this message]
2003-03-24 21:30 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E7F837E.9020900@splentec.com \
--to=luben@splentec.com \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.