All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] scsi_ioctl.c for SEND_DIAGNOSTIC
Date: Wed, 26 Mar 2003 20:02:07 +1000	[thread overview]
Message-ID: <3E817A9F.7090502@torque.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

While doing foreground extended self tests with
smartmontools I found that the timeout was much to
short for SCSI_IOCTL_SEND_COMMAND. On my 18 GB
disk that test takes about 12 minutes.

Attachment extends timeout to the same as FORMAT
(i.e. 2 hours). The patch is against lk 2.5.66 .

BTW Foreground extended self tests (and FORMATs :-))
should not be done on disks with mounted partitions.

Doug Gilbert

[-- Attachment #2: scsi_ioctl_2566.diff --]
[-- Type: text/plain, Size: 302 bytes --]

--- linux/drivers/scsi/scsi_ioctl.c	2003-03-05 21:01:15.000000000 +1000
+++ linux/drivers/scsi/scsi_ioctl.c2566dpg	2003-03-26 19:47:18.000000000 +1000
@@ -298,6 +298,7 @@
 		goto error;
 
 	switch (opcode) {
+	case SEND_DIAGNOSTIC:
 	case FORMAT_UNIT:
 		timeout = FORMAT_UNIT_TIMEOUT;
 		retries = 1;

                 reply	other threads:[~2003-03-26 10:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E817A9F.7090502@torque.net \
    --to=dougg@torque.net \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.