From: Matthew Dobson <colpatch@us.ibm.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@digeo.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] (2.5.66-mm2) War on warnings
Date: Tue, 01 Apr 2003 11:32:28 -0800 [thread overview]
Message-ID: <3E89E94C.4040004@us.ibm.com> (raw)
In-Reply-To: 25070000.1049213622@[10.10.2.4]
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
And whilst we're stomping warnings, here are a couple more I noticed in
various compilations...
-Matt
[-- Attachment #2: warning_fixes-2.5.66.patch --]
[-- Type: text/plain, Size: 1799 bytes --]
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.66-vanilla/drivers/char/drm/r128_cce.c linux-2.5.66-warnings/drivers/char/drm/r128_cce.c
--- linux-2.5.66-vanilla/drivers/char/drm/r128_cce.c Mon Mar 24 14:00:07 2003
+++ linux-2.5.66-warnings/drivers/char/drm/r128_cce.c Mon Mar 31 11:55:16 2003
@@ -352,7 +352,7 @@
entry->busaddr[page_ofs]);
DRM_DEBUG( "ring rptr: offset=0x%08x handle=0x%08lx\n",
entry->busaddr[page_ofs],
- entry->handle + tmp_ofs );
+ (unsigned long)entry->handle + tmp_ofs );
}
/* Set watermark control */
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.66-vanilla/drivers/net/tulip/interrupt.c linux-2.5.66-warnings/drivers/net/tulip/interrupt.c
--- linux-2.5.66-vanilla/drivers/net/tulip/interrupt.c Mon Mar 24 14:00:10 2003
+++ linux-2.5.66-warnings/drivers/net/tulip/interrupt.c Mon Mar 31 11:55:16 2003
@@ -198,7 +198,7 @@
dev->name,
le32_to_cpu(tp->rx_ring[entry].buffer1),
tp->rx_buffers[entry].mapping,
- skb->head, temp);
+ (unsigned long)skb->head, temp);
}
#endif
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.66-vanilla/drivers/scsi/scsi_sysfs.c linux-2.5.66-warnings/drivers/scsi/scsi_sysfs.c
--- linux-2.5.66-vanilla/drivers/scsi/scsi_sysfs.c Mon Mar 24 14:00:08 2003
+++ linux-2.5.66-warnings/drivers/scsi/scsi_sysfs.c Mon Mar 31 11:56:02 2003
@@ -272,14 +272,17 @@
return 0;
}
+void scsi_rescan_device(struct scsi_device *);
static ssize_t
store_rescan_field (struct device *dev, const char *buf, size_t count)
{
int ret = ENODEV;
struct scsi_device *sdev;
sdev = to_scsi_device(dev);
- if (sdev)
- ret = scsi_rescan_device(sdev);
+ if (sdev){
+ ret = 0;
+ scsi_rescan_device(sdev);
+ }
return ret;
}
next prev parent reply other threads:[~2003-04-01 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 15:22 [PATCH] (2.5.66-mm2) War on warnings Martin J. Bligh
2003-04-01 15:27 ` Jeff Garzik
2003-04-01 16:13 ` Martin J. Bligh
2003-04-01 18:37 ` Matthew Dobson
2003-04-01 19:30 ` Matthew Dobson
2003-04-01 19:32 ` Matthew Dobson [this message]
2003-04-01 19:36 ` Martin J. Bligh
2003-04-01 16:14 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E89E94C.4040004@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=akpm@digeo.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.