Re: [PATCH] CLASSIFY target

[Patrick McHardy <kaber@trash.net>]

Hi Martin,
thanks for your response,

Martin Josefsson wrote:

>Regarding this patch... iirc, Bert Hubert wrote a similar target a while
>ago and I think he wanted a small change in the core QoS stuff and that
>was voted down, might be something to look into?
>
>I think the discussion took place on the netdev list.
>

Google found a discussion about moving "skb->priority = sk->priority" 
line to
ip_queue_xmit2 to allow netfilter targets to override SO_PRIORITY value of
local sockets. A quick check told me this change was never made, so the
CLASSIFY target is only working correctly in the POST_ROUTING chain, which
is what i have tested. This doesn't seem to affect usage of the target, 
worse
would be if POST_ROUTING didn't work correctly. My suggestion is to
restrict usage to POST_ROUTING chain, this seems like a natural place for
QoS classification. What do you think ?

Thanks,
Patrick