From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/rcpci45 DMA mapping API conversion
Date: Sat, 19 Apr 2003 16:09:01 -0400 [thread overview]
Message-ID: <3EA1ACDD.4090306@pobox.com> (raw)
In-Reply-To: <20030419215526.A3020@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Re,
>
> Jeff Garzik <jgarzik@pobox.com> :
> [...]
>
>>Ok, I finally got around to attacking this one. Your patch looked ok to
>>me until I noticed one detail:
>>
>> pDpa->msgbuf = kmalloc (MSG_BUF_SIZE, GFP_DMA | GFP_KERNEL);
>>
>>The GFP_DMA tag indicates that we can't just use pci_alloc_consistent in
>>the normal way, as we lose the GFP_DMA designator.
>
>
> Does it mean the usual pci_set_dma_mask() cooking or something more elaborate ?
Reading dma_alloc_coherent() in arch/i386/kernel/pci-dma.c, it does
appear that would be sufficient...
Jeff
next prev parent reply other threads:[~2003-04-19 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-05 13:45 [PATCH] drivers/net/rcpci45 DMA mapping API conversion Francois Romieu
2003-04-19 19:01 ` Jeff Garzik
2003-04-19 19:55 ` Francois Romieu
2003-04-19 20:09 ` Jeff Garzik [this message]
2003-04-19 20:43 ` Francois Romieu
2003-04-19 19:04 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EA1ACDD.4090306@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.