From: "H. Peter Anvin" <hpa@zytor.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new system call mknod64
Date: Mon, 21 Apr 2003 19:52:04 -0700 [thread overview]
Message-ID: <3EA4AE54.80607@zytor.com> (raw)
In-Reply-To: <20030422020153.GA18141@mail.jlokier.co.uk>
Jamie Lokier wrote:
>>
>>The main advantage with making it a struct is that it keep people from
>>doing stupid stuff like (int)dev where dev is a kdev_t... There is
>>all kinds of shit like that in the kernel...
>
> If you want that good quality 64-bit code, try making it a struct
> containing just a u64 :)
>
Perhaps:
#if BITS_PER_LONG == 64
typedef struct { u64 val; } kdev_t;
/* Macros for major minor mkdev */
#else
typedef struct { u32 major, minor; } kdev_t;
/* Macros... */
#endif
-hpa
next prev parent reply other threads:[~2003-04-22 2:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-22 1:02 [PATCH] new system call mknod64 Andries.Brouwer
2003-04-22 1:32 ` H. Peter Anvin
2003-04-22 2:01 ` Jamie Lokier
2003-04-22 2:52 ` H. Peter Anvin [this message]
2003-04-22 6:00 ` jw schultz
2003-04-22 17:17 ` H. Peter Anvin
[not found] <20030421215009$2052@gated-at.bofh.it>
[not found] ` <20030421231010$7ee3@gated-at.bofh.it>
[not found] ` <20030422000016$17e3@gated-at.bofh.it>
[not found] ` <20030422083014$0fe2@gated-at.bofh.it>
2003-04-22 20:02 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2003-04-21 21:48 Andries.Brouwer
2003-04-21 22:07 ` Linus Torvalds
2003-04-21 21:43 Andries.Brouwer
2003-04-21 23:02 ` H. Peter Anvin
2003-04-21 23:50 ` Jamie Lokier
2003-04-22 8:24 ` Shachar Shemesh
2003-04-20 22:12 Andries.Brouwer
2003-04-21 6:31 ` H. Peter Anvin
2003-04-20 21:26 Andries.Brouwer
2003-04-20 21:43 ` David S. Miller
2003-04-20 21:56 ` Linus Torvalds
2003-04-21 11:59 ` Roman Zippel
2003-04-21 18:01 ` Linus Torvalds
2003-04-21 18:10 ` Christoph Hellwig
2003-04-21 18:21 ` viro
2003-04-21 18:22 ` Linus Torvalds
2003-04-21 18:27 ` viro
2003-04-21 18:35 ` Linus Torvalds
2003-04-21 18:54 ` viro
2003-04-21 19:16 ` Jörn Engel
2003-04-21 18:35 ` Christoph Hellwig
2003-04-21 18:42 ` H. Peter Anvin
2003-04-21 18:44 ` Linus Torvalds
2003-04-21 18:47 ` Christoph Hellwig
2003-04-21 18:58 ` viro
2003-04-21 19:05 ` Linus Torvalds
2003-04-21 19:35 ` viro
2003-04-21 20:02 ` Linus Torvalds
2003-04-21 19:04 ` Linus Torvalds
2003-04-21 19:59 ` H. Peter Anvin
2003-04-21 18:51 ` H. Peter Anvin
2003-04-21 23:49 ` Roman Zippel
2003-04-20 20:34 Andries.Brouwer
2003-04-20 21:12 ` David S. Miller
2003-04-20 18:39 Andries.Brouwer
2003-04-20 18:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EA4AE54.80607@zytor.com \
--to=hpa@zytor.com \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.