From: "Kip Walker" <kwalker@broadcom.com>
To: linux-mips@linux-mips.org
Subject: Re: [pathch] kernel/sched.c bogon?
Date: Fri, 25 Apr 2003 08:28:22 -0700 [thread overview]
Message-ID: <3EA95416.BD37F40@broadcom.com> (raw)
In-Reply-To: 3E67EF64.152CFC6C@broadcom.com
Ralf? I'm tying up loose ends between my tree and yours, and hoping to
push some things back.
Kip Walker wrote:
>
> The comparisons of oldest_idle below trigger compiler warnings and
> should probably be safely type-cast:
>
> Kip
>
> Index: kernel/sched.c
> ===================================================================
> RCS file: /home/cvs/linux/kernel/sched.c,v
> retrieving revision 1.64.2.6
> diff -u -r1.64.2.6 sched.c
> --- kernel/sched.c 25 Feb 2003 22:03:13 -0000 1.64.2.6
> +++ kernel/sched.c 7 Mar 2003 00:57:35 -0000
> @@ -282,7 +282,7 @@
> target_tsk = tsk;
> }
> } else {
> - if (oldest_idle == -1ULL) {
> + if (oldest_idle == (cycles_t) -1) {
> int prio = preemption_goodness(tsk, p,
> cpu);
>
> if (prio > max_prio) {
> @@ -294,7 +294,7 @@
> }
> tsk = target_tsk;
> if (tsk) {
> - if (oldest_idle != -1ULL) {
> + if (oldest_idle != (cycles_t) -1) {
> best_cpu = tsk->processor;
> goto send_now_idle;
> }
prev parent reply other threads:[~2003-04-25 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-07 1:01 [pathch] kernel/sched.c bogon? Kip Walker
2003-03-07 1:40 ` Jun Sun
2003-03-10 12:55 ` Ralf Baechle
2003-03-10 17:59 ` Jun Sun
2003-04-24 17:03 ` Kip Walker
2003-04-25 15:28 ` Kip Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EA95416.BD37F40@broadcom.com \
--to=kwalker@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.