From: Olof Johansson <olof@austin.ibm.com>
To: trond.myklebust@fys.uio.no, nfs@lists.sourceforge.net
Subject: [PATCH] SVC sockets don't disable Nagle
Date: Tue, 29 Apr 2003 17:03:19 -0500 [thread overview]
Message-ID: <3EAEF6A7.1000806@austin.ibm.com> (raw)
I noticed that the Nagle algorithm was disabled just recently on the
client side, while it still seems to be enabled on the server side. The
previous patch came from Chuck Lever.
Below patch disables it on the server side as well. For latency reasons,
this should be the desired behaviour NFS at both client and server.
Diff is against 2.4.21-rc1.
---------------------------
--- linux-2.4.21-rc1/net/sunrpc/svcsock.c.orig
+++ linux-2.4.21-rc1/net/sunrpc/svcsock.c
@@ -932,6 +932,7 @@ static int
svc_tcp_init(struct svc_sock *svsk)
{
struct sock *sk = svsk->sk_sk;
+ struct tcp_opt *tp = &(sk->tp_pinfo.af_tcp);
svsk->sk_recvfrom = svc_tcp_recvfrom;
svsk->sk_sendto = svc_tcp_sendto;
@@ -948,6 +949,8 @@ svc_tcp_init(struct svc_sock *svsk)
svsk->sk_reclen = 0;
svsk->sk_tcplen = 0;
+ tp->nonagle = 1; /* disable Nagle's algorithm */
+
/* initialise setting must have enough space to
* receive and respond to one request.
* svc_tcp_recvfrom will re-adjust if necessary
---------------------------
Thanks,
Olof
--
Olof Johansson Office: 4E002/905
pSeries Linux Development IBM Systems Group
Email: olof@austin.ibm.com Phone: 512-838-9858
All opinions are my own and not those of IBM.
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next reply other threads:[~2003-04-29 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 22:03 Olof Johansson [this message]
2003-04-29 22:42 ` [PATCH] SVC sockets don't disable Nagle Bogdan Costescu
2003-04-30 0:07 ` Olof Johansson
2003-04-30 12:06 ` Bogdan Costescu
2003-04-30 12:45 ` Trond Myklebust
2003-04-30 14:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EAEF6A7.1000806@austin.ibm.com \
--to=olof@austin.ibm.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.