From: Michael Hunold <hunold@convergence.de>
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com
Subject: [PATCH[[2.5][9-11] correct the i2c address of the saa7111
Date: Tue, 06 May 2003 18:21:36 +0200 [thread overview]
Message-ID: <3EB7E110.80500@convergence.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
Hello,
this patch corrects the i2c address from "34>>1" to 0x24 and 0x25.
Believe me -- or look at the data sheet, for example from
http://www.gdv.uni-hannover.de/~hunold1/linux/saa7146/specs/saa7111a.pdf
Page 41 says: "Slave address read = 49H or 4BH; note 2 write = 48H or 4AH"
They use 8-bit addresses here, but i2c addresses are 7-bit, ie. 0x48>>1
== 0x24 and 0x4a>>1 = 0x25
Please apply.
Thanks
Michael Hunold.
[-- Attachment #2: 09-saa7111-i2c-address-fixup.diff --]
[-- Type: text/plain, Size: 558 bytes --]
diff -uNrwB -x '*.o' --new-file linux-2.5.69/drivers/media/video/saa7111.c linux-2.5.69.patch/drivers/media/video/saa7111.c
--- linux-2.5.69/drivers/media/video/saa7111.c 2003-05-06 13:16:21.000000000 +0200
+++ linux-2.5.69.patch/drivers/media/video/saa7111.c 2003-05-06 17:18:27.000000000 +0200
@@ -57,7 +57,7 @@
int sat;
};
-static unsigned short normal_i2c[] = { 34>>1, I2C_CLIENT_END };
+static unsigned short normal_i2c[] = { 0x24, 0x25, I2C_CLIENT_END };
static unsigned short normal_i2c_range[] = { I2C_CLIENT_END };
I2C_CLIENT_INSMOD;
reply other threads:[~2003-05-06 16:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB7E110.80500@convergence.de \
--to=hunold@convergence.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.