All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "Grover, Andrew" <andrew.grover@intel.com>
Cc: Andrew Morton <akpm@digeo.com>, Nicolas <linux@1g6.biz>,
	linux-kernel@vger.kernel.org
Subject: Re: oops 2.5.68 ohci1394/ IRQ/acpi
Date: Tue, 06 May 2003 14:36:36 -0400	[thread overview]
Message-ID: <3EB800B4.40204@pobox.com> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A84725A28E@orsmsx401.jf.intel.com>

Grover, Andrew wrote:
> Ohhh so we need to not just return nonzero, but return 1 (aka
> IRQ_HANDLED?) Well, then this makes sense. Sorry about that.
> 
> btw I think the line in handle_IRQ_event that reads
> 
> if (retval != 1) {
> 
> should be
> 
> if (retval != IRQ_HANDLED) {


Then I must further nit-pick:  if IRQ_HANDLED is considered "non-zero" 
the above test should be against IRQ_NONE, to avoid directly considering 
any single value _the_ non-zero value...

	Jeff




  reply	other threads:[~2003-05-06 18:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-06 18:13 oops 2.5.68 ohci1394/ IRQ/acpi Grover, Andrew
2003-05-06 18:36 ` Jeff Garzik [this message]
2003-05-06 20:42 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2003-05-05 11:50 Nicolas
2003-05-05 21:16 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EB800B4.40204@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@digeo.com \
    --cc=andrew.grover@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@1g6.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.