From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.69-bk7: multiple definition of `usb_gadget_get_string'
Date: Mon, 12 May 2003 17:06:29 -0700 [thread overview]
Message-ID: <3EC03705.8040100@pacbell.net> (raw)
In-Reply-To: 20030512211159.GA29716@kroah.com
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Greg KH wrote:
> On Mon, May 12, 2003 at 10:58:48PM +0200, Adrian Bunk wrote:
>>`usb_gadget_get_string':
>>: multiple definition of `usb_gadget_get_string'
>>drivers/usb/gadget/g_zero.o(.text+0x0): first defined here
>>make[2]: *** [drivers/usb/gadget/built-in.o] Error 1
>
>
> I don't think that g_zero and g_ether are allowed to be built into the
> kernel at the same time. David, want to send a patch to fix the Kconfig
> file to prevent this?
Yes, just one: there's only one upstream USB connector,
it can only have one driver. Patch attached.
Seems like the xconfig/menuconfig coredumps I previously
saw with tristate choice/endchoice are now gone ... or at
least they don't show up with this many choices!
- Dave
[-- Attachment #2: kconf.patch --]
[-- Type: text/plain, Size: 1306 bytes --]
--- 1.2/drivers/usb/gadget/Kconfig Tue May 6 05:34:53 2003
+++ edited/drivers/usb/gadget/Kconfig Mon May 12 16:56:45 2003
@@ -35,9 +35,8 @@
#
# USB Peripheral Controller Support
#
-# FIXME convert to tristate choice when "choice" behaves as specified
-#
-comment "USB Peripheral Controller Support"
+choice
+ prompt "USB Peripheral Controller Support"
depends on USB_GADGET
config USB_NET2280
@@ -55,19 +54,17 @@
dynamically linked module called "net2280" and force all
gadget drivers to also be dynamically linked.
+endchoice
+
#
# USB Gadget Drivers
#
-# FIXME only one of these may be statically linked; choice/endchoice.
-#
-comment "USB Gadget Drivers"
+choice
+ prompt "USB Gadget Drivers"
depends on USB_GADGET
+ default USB_ETH
-# FIXME want better dependency/config approach for drivers. with only
-# two knobs to tweak (driver y/m/n, and a hardware symbol) there's no
-# good excuse for Kconfig to cause such trouble here. there are clear
-# bugs (coredumps, multiple choices enabled, and more) in its (boolean)
-# "choice" logic too ...
+# FIXME want a cleaner dependency/config approach for drivers.
config USB_ZERO
tristate "Gadget Zero (DEVELOPMENT)"
@@ -149,5 +146,7 @@
bool
depends on USB_ETH && USB_SA1100
default y
+
+endchoice
# endmenuconfig
next prev parent reply other threads:[~2003-05-12 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-12 20:58 2.5.69-bk7: multiple definition of `usb_gadget_get_string' Adrian Bunk
2003-05-12 21:11 ` Greg KH
2003-05-13 0:06 ` David Brownell [this message]
2003-05-13 15:35 ` Roman Zippel
2003-05-13 20:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC03705.8040100@pacbell.net \
--to=david-b@pacbell.net \
--cc=bunk@fs.tum.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.