All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Douglas Gilbert <dougg@torque.net>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] include/scsi/scsi.h replace u8 in 2.5.69
Date: Wed, 14 May 2003 09:05:08 -0400	[thread overview]
Message-ID: <3EC23F04.8000404@pobox.com> (raw)
In-Reply-To: <20030514090218.A7371@infradead.org>

Christoph Hellwig wrote:
> On Wed, May 14, 2003 at 04:39:43PM +1000, Douglas Gilbert wrote:
> 
>>Here is a simple patch to replace the single occurrence
>>of "u8" with "u_char" in include/scsi/scsi.h .
> 
> 
> That's wrong.  No userland should include kernwel headers.
> (and u_char is a non-standard type, too).


Agreed.  And like Douglas guessed, uint8_t is preferred over u_char :)

	Jeff




  reply	other threads:[~2003-05-14 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-14  6:39 [PATCH] include/scsi/scsi.h replace u8 in 2.5.69 Douglas Gilbert
2003-05-14  8:02 ` Christoph Hellwig
2003-05-14 13:05   ` Jeff Garzik [this message]
2003-05-14 13:10   ` Douglas Gilbert
2003-05-14 13:14     ` Christoph Hellwig
2003-05-14 13:54     ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EC23F04.8000404@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=dougg@torque.net \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.