From: Luben Tuikov <tluben@rogers.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mike Anderson <andmike@us.ibm.com>, linux-scsi@vger.kernel.org
Subject: Re: Patch: change the serial_number for error-handler commands
Date: Tue, 20 May 2003 17:25:26 -0400 [thread overview]
Message-ID: <3ECA9D46.7010301@rogers.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0305191433280.1042-100000@ida.rowland.org>
Alan Stern wrote:
> ===== scsi_error.c 1.27 vs edited =====
> --- 1.27/drivers/scsi/scsi_error.c Sun May 4 12:50:44 2003
> +++ edited/drivers/scsi/scsi_error.c Mon May 19 14:17:04 2003
> @@ -753,6 +753,8 @@
> scmd->cmd_len = COMMAND_SIZE(scmd->cmnd[0]);
> scmd->underflow = 0;
> scmd->sc_data_direction = SCSI_DATA_NONE;
> + if ((scmd->serial_number -= 999999) == 0)
> + scmd->serial_number -= 999999;
>
> rtn = scsi_send_eh_cmnd(scmd, SENSE_TIMEOUT);
Alan, could you please explain this patch?
This looks like:
if (sn == 999999)
sn = -sn;
for _that_ particular command, but scsi_core->sn stays unchanged...
Q: Which value does USB Storage reserve for cmdsn, 0 or MAX?
--
Luben
next prev parent reply other threads:[~2003-05-20 21:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030516190414.GD11884@iucha.net>
2003-05-16 21:23 ` [linux-usb-devel] USB Storage oops in 2.5.69-bk8 Alan Stern
2003-05-16 21:44 ` Florin Iucha
2003-05-16 22:29 ` Mike Anderson
2003-05-17 15:29 ` Alan Stern
2003-05-17 16:33 ` David Brownell
2003-05-18 18:31 ` Alan Stern
2003-05-18 23:46 ` David Brownell
2003-05-21 15:19 ` Bug in hot-unplugging for SCSI CD-ROM Alan Stern
2003-05-17 18:38 ` [linux-usb-devel] USB Storage oops in 2.5.69-bk8 Patrick Mansfield
2003-05-31 14:35 ` Florin Iucha
2003-05-20 14:11 ` Patch: change the serial_number for error-handler commands Alan Stern
2003-05-20 21:25 ` Luben Tuikov [this message]
2003-05-21 1:19 ` Alan Stern
2003-05-21 18:03 ` Mike Anderson
2003-05-21 18:50 ` Luben Tuikov
2003-05-21 19:18 ` Luben Tuikov
2003-05-21 20:28 ` Mike Anderson
2003-05-21 21:11 ` Luben Tuikov
2003-05-21 23:15 ` Patrick Mansfield
2003-05-22 5:47 ` Luben Tuikov
2003-05-21 19:57 ` Alan Stern
2003-05-21 20:42 ` Luben Tuikov
2003-05-21 21:05 ` Alan Stern
2003-05-21 21:19 ` James Bottomley
2003-05-21 22:53 ` Mike Anderson
2003-06-11 17:41 ` PATCH: (as33) Remove /proc/scsi directory in scsi_remove_host() Alan Stern
2003-06-11 18:23 ` Mike Anderson
2003-06-12 6:04 ` Christoph Hellwig
2003-06-12 6:51 ` Mike Anderson
2003-06-12 21:00 ` PATCH: (as33b) " Alan Stern
2003-06-12 21:58 ` Mike Anderson
2003-06-13 14:38 ` Alan Stern
2003-06-15 13:01 ` Christoph Hellwig
2003-05-21 19:24 ` Patch: change the serial_number for error-handler commands Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ECA9D46.7010301@rogers.com \
--to=tluben@rogers.com \
--cc=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.