From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: RFC: move hosts.h, scsi.h
Date: Thu, 22 May 2003 21:52:32 -0400 [thread overview]
Message-ID: <3ECD7EE0.1000507@pobox.com> (raw)
In-Reply-To: <20030522214555.A13150@infradead.org>
Christoph Hellwig wrote:
> On Thu, May 22, 2003 at 04:34:53PM -0400, Jeff Garzik wrote:
>
>>I request permission to do the following:
>>
>>1) bk mv drivers/scsi/scsi.h include/linux
>>2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
>>3) bk mv drivers/scsi/scsi_obsolete.h include/linux
>>4) create shell drivers/scsi/{...}.h that includes just-moved files, so
>>to preserve full driver source compatibility.
>>5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
>>"scsi_obsolete.h"
>>
>>Objections/comments?
>
>
> It's not that easy. The current host.h/scsi.h split is silly we either want
> to merge them or better split them saner (and into more pieces). The current
> scsi_obsolete.h should go away completly, it may make a driver compile but
> not work (missing EH). OTOH all those ugly typedefs should move into a 'new'
> onbsolete.h. Also all this should go into include/scsi/
This is a whole list of steps to perform after I submit the above changes :)
Sure there are many other improvements to be made. What I suggest is
one small step in that direction. It's an important step because it's
the minimum necessary to get a sane include structure, with minimum
controversy. It's also backport-able to 2.4.
Since files are now just a "bk mv" away from a new pathname, a new file
location may easily be debated and then implemented, at a later date.
Jeff
next prev parent reply other threads:[~2003-05-23 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 20:34 RFC: move hosts.h, scsi.h Jeff Garzik
2003-05-22 20:45 ` Christoph Hellwig
2003-05-22 21:59 ` Andries Brouwer
2003-05-23 1:52 ` Jeff Garzik [this message]
2003-05-22 21:04 ` Andries Brouwer
2003-05-23 1:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ECD7EE0.1000507@pobox.com \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.