From: Dan Malek <dan@embeddededge.com>
To: Jean-Denis Boyer <jdboyer@m5t.com>
Cc: Tom Rini <trini@kernel.crashing.org>,
linuxppc-embedded@lists.linuxppc.org
Subject: Re: PATCH: arch/ppc/8xx_io_fec.c
Date: Wed, 28 May 2003 07:01:13 -0400 [thread overview]
Message-ID: <3ED496F9.4090402@embeddededge.com> (raw)
In-Reply-To: AB5AF73EAF23304EA1B932174137CED7030368@m5tmail.m5t.com
Jean-Denis Boyer wrote:
> I tested on revisions B3 and D4, and did not see any problem.
> Anyway, fec_stop was already disabling the FEC,
> so if it was a problem, it would have broken there.
OK. Just remember I mentioned this and be ready to fix it
when someone complains. :-)
> Do you mean for the mixed tabs/spaces? :-( Sorry for that one...
> I will fix and resubmit as soon as everyone agree on the changes.
Yes, and there is a Linux coding standards document that would be
nice if people followed:
if (condition) {
not,
if(condition){, or if( condition ){, or other weird variations
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-05-28 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 19:47 PATCH: arch/ppc/8xx_io_fec.c Jean-Denis Boyer
2003-05-28 11:01 ` Dan Malek [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-28 13:57 Steven Rothweiler
2003-05-27 14:38 Jean-Denis Boyer
2003-05-27 16:58 ` Tom Rini
2003-05-27 19:33 ` Dan Malek
2003-05-27 20:13 ` Tom Rini
2003-05-28 11:04 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED496F9.4090402@embeddededge.com \
--to=dan@embeddededge.com \
--cc=jdboyer@m5t.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.