Re: [PATCH] complete nfnl_talk

[Patrick McHardy <kaber@trash.net>]

One tought about the patch:

> int nfnl_talk(struct nfnl_handle *nfnlh, struct nlmsghdr *n, pid_t peer,
> 	      unsigned groups, struct nlmsghdr *answer,
> 	      int (*junk)(struct sockaddr_nl *, struct nlmsghdr *n, void *),
> 	      void *jarg)
> 
>
...

> 
>+			if (h->nlmsg_type == NLMSG_ERROR) {
>+				struct nlmsgerr *err = NLMSG_DATA(h);
>+				if (l < sizeof(struct nlmsgerr))
>+					nfnl_error("ERROR truncated\n");
>+				else {
>+					errno = -err->error;
>+					if (errno == 0) {
>+						if (answer)
>+							memcpy(answer, h, h->nlmsg_len);
>+						return 0;
>+					}
>+					perror("CTNETLINK answers");
>+				}
>+				return -1;
>  
>

applications might want to handle the error themselves, an alternative 
would be:

errno = -err->error;
if (anwer) {
        memcpy(answer, h, h->nlmsg_len);
        return errno;
} else if (errno)
        perror("CTNETLINK answers);
return errno;

What do you think ?
Patrick