From: Krishna Kumar <krkumar@us.ibm.com>
To: kuznet@ms2.inr.ac.ru, "David S. Miller" <davem@redhat.com>,
netdev@oss.sgi.com, linux-net@vger.kernel.org
Subject: [PATCH] Panic in ipv6_add_dev
Date: Mon, 09 Jun 2003 17:55:46 -0700 [thread overview]
Message-ID: <3EE52C92.4060509@us.ibm.com> (raw)
Hi,
I am using 2.5.70 and using VLAN to configure many interfaces, and after some
are configured, the system panics in unregister_sysctl_table called from (STACK)
neigh_sysctl_unregister, neigh_parms_release, ipv_add_dev. The problem is that
we have called neigh_parms_alloc, but not neigh_sysctl_register. Hence calling
neigh_parms_release() in the middle frees up the sysctl_header entry for the
nd_table as a side-effect (due to the memcpy in neigh_parms_alloc).
We need to initialize sysctl_table to NULL in neigh_parms_alloc so that a
release can be called safely at any time.
Thanks,
- KK
diff -ruN linux-2.5.70.org/net/core/neighbour.c linux-2.5.70/net/core/neighbour.c
--- linux-2.5.70.org/net/core/neighbour.c 2003-06-09 17:32:10.000000000 -0700
+++ linux-2.5.70/net/core/neighbour.c 2003-06-09 17:36:22.000000000 -0700
@@ -1094,6 +1094,7 @@
kfree(p);
return NULL;
}
+ p->sysctl_table = NULL;
write_lock_bh(&tbl->lock);
p->next = tbl->parms.next;
tbl->parms.next = p;
next reply other threads:[~2003-06-10 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-10 0:55 Krishna Kumar [this message]
2003-06-10 4:56 ` [PATCH] Panic in ipv6_add_dev YOSHIFUJI Hideaki / 吉藤英明
2003-06-12 6:35 ` David S. Miller
2003-06-12 6:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EE52C92.4060509@us.ibm.com \
--to=krkumar@us.ibm.com \
--cc=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.