All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pantelis Antoniou <panto@intracom.gr>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Status LEDs status?
Date: Tue, 10 Jun 2003 09:48:08 +0300	[thread overview]
Message-ID: <3EE57F28.1020208@intracom.gr> (raw)
In-Reply-To: <20030609204914.C6F79C5FD7@atlas.denx.de>

Wolfgang Denk wrote:

>In message <3EE47B1C.3090601@intracom.gr> you wrote:
>
snip

>
>If you have such a patch, please submit it. But please  note  that  I
>don't want to add any CPU specific code in the drivers/ directory.
>
>Best regards,
>
>Wolfgang Denk
>
>
OK

How about this patch.

The main idea is to do all the hardware specific stuff
in a header while the file in the drivers directory
is very simple and common to all the configurations.

The key is the new include file mpc_led.h which
implements the current behaviour for the 8xx/8260/5xx.

If your board has LEDs that don't fall into
the current scheme then in the board include file
you define CONFIG_BOARD_SPECIFIC_LED and provide
the __led_init __led_toggle and __led_set inline functions.

IMHO this cleans up the current scheme, allows boards
that have non standard LED configurations to work, and
I think makes it easier for arches other that ppc to
support LEDs.

Regards

Pantelis

  reply	other threads:[~2003-06-10  6:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-09  9:26 [U-Boot-Users] Status LEDs status? Pantelis Antoniou
2003-06-09 10:07 ` Wolfgang Denk
2003-06-09 11:30   ` Pantelis Antoniou
2003-06-09 11:54     ` Wolfgang Denk
2003-06-09 12:18       ` Pantelis Antoniou
2003-06-09 20:49         ` Wolfgang Denk
2003-06-10  6:48           ` Pantelis Antoniou [this message]
2003-06-19 18:42             ` Wolfgang Denk
2003-06-10  6:49           ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EE57F28.1020208@intracom.gr \
    --to=panto@intracom.gr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.