From: Nick Piggin <piggin@cyberone.com.au>
To: Robert Love <rml@tech9.net>
Cc: Andrew Morton <akpm@digeo.com>,
bos@serpentine.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] as-iosched divide by zero fix
Date: Thu, 12 Jun 2003 11:22:58 +1000 [thread overview]
Message-ID: <3EE7D5F2.1070508@cyberone.com.au> (raw)
In-Reply-To: <1055380257.662.8.camel@localhost>
Robert Love wrote:
>On Wed, 2003-06-11 at 17:24, Andrew Morton wrote:
>
>
>>Do you know what the actual oops is?
>>
>
>I got it all figured out now.
>
>It is a divide by zero in update_write_batch() called from
>as_completed_request().
>
>
>>Odd that starting the X server triggers it. Be interesting if your patch
>>fixes things for Brian.
>>
>
>I reproduced it without X.
>
>The divide by zero is on line 959 with the divide by 'write_time'. It
>can obviously be zero (see line 950). The divide by 'batch' on line 953
>seems safe.
>
>The correct patch is below.
>
Probably put in the other check to be on the safe side.
And can the check be if (!write_time || (batch / write_time > 2)
>
>
>Most important question: why are only some of us seeing this?
>
It would occur if a write batch didn't take any jiffies, which
isn't very likely. The HZ=100 change probbly brought it out.
Thanks guys.
next prev parent reply other threads:[~2003-06-12 1:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 22:17 2.5.70-mm8: freeze after starting X Bryan O'Sullivan
2003-06-11 22:36 ` Robert Love
2003-06-11 22:41 ` Andrew Morton
2003-06-11 22:53 ` Bryan O'Sullivan
2003-06-11 23:11 ` Bryan O'Sullivan
2003-06-11 23:34 ` Robert Love
2003-06-12 0:18 ` Robert Love
2003-06-12 0:24 ` Andrew Morton
2003-06-12 1:10 ` [patch] as-iosched divide by zero fix Robert Love
2003-06-12 1:22 ` Andrew Morton
2003-06-12 1:28 ` Robert Love
2003-06-12 1:41 ` Nick Piggin
2003-06-12 1:31 ` Nick Piggin
2003-06-12 2:34 ` John Stoffel
2003-06-12 4:05 ` Nick Piggin
2003-06-12 1:22 ` Nick Piggin [this message]
2003-06-12 1:29 ` Robert Love
2003-06-12 1:54 ` Steven Cole
2003-06-12 2:01 ` Robert Love
2003-06-12 17:19 ` 2.5.70-mm8: freeze after starting X Bryan O'Sullivan
2003-06-12 17:29 ` Bryan O'Sullivan
2003-06-12 17:30 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EE7D5F2.1070508@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@digeo.com \
--cc=bos@serpentine.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.