From: Corey Minyard <cminyard@mvista.com>
To: Adrian Bunk <bunk@fs.tum.de>, Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Corey Minyard <minyard@mvista.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [2.4 patch] fix IPMI compile with new ACPI
Date: Sun, 22 Jun 2003 16:37:13 -0500 [thread overview]
Message-ID: <3EF62189.1020105@mvista.com> (raw)
In-Reply-To: <20030621235417.GH23337@fs.tum.de>
Cool, they've fixed the ACPI stuff. It looks good, please apply.
-Corey
Adrian Bunk wrote:
>The patch below fixes the compilation of ipmi_kcs_intf.c in 2.4.22-pre1.
>
>The changes are:
>- remove two now unneeded includes (since the files moved there was a
> compile error, but they are indirectly included via linux/acpi.h)
>- remove unneeded COMPILER_DEPENDENT_UINT64; besides that it's
> unneeded it was wrong on 32 bit architectures
>- s/acpi_table_header/struct acpi_table_header/
>
>-ac contains a similar patch that differs because it also adds
>#include's for acpi/acpi.h and acpi/actypes.h (indirectly included via
>linux/acpi.h).
>
>cu
>Adrian
>
>--- linux-2.4.22-pre1-full/drivers/char/ipmi/ipmi_kcs_intf.c.old 2003-06-22 01:28:28.000000000 +0200
>+++ linux-2.4.22-pre1-full/drivers/char/ipmi/ipmi_kcs_intf.c 2003-06-22 01:40:12.000000000 +0200
>@@ -1031,10 +1031,6 @@
> from Hewlett-Packard simple bmc.c, a GPL KCS driver. */
>
> #include <linux/acpi.h>
>-/* A real hack, but everything's not there yet in 2.4. */
>-#define COMPILER_DEPENDENT_UINT64 unsigned long
>-#include <../drivers/acpi/include/acpi.h>
>-#include <../drivers/acpi/include/actypes.h>
>
> struct SPMITable {
> s8 Signature[4];
>@@ -1059,7 +1055,7 @@
> static unsigned long acpi_find_bmc(void)
> {
> acpi_status status;
>- acpi_table_header *spmi;
>+ struct acpi_table_header *spmi;
> static unsigned long io_base = 0;
>
> if (io_base != 0)
>
>
>
>
prev parent reply other threads:[~2003-06-22 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-21 23:54 [2.4 patch] fix IPMI compile with new ACPI Adrian Bunk
2003-06-22 21:37 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EF62189.1020105@mvista.com \
--to=cminyard@mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=minyard@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.