From: mds@paradyne.com (Mark D. Studebaker )
To: lm-sensors@vger.kernel.org
Subject: mkpatch works
Date: Thu, 19 May 2005 06:24:02 +0000 [thread overview]
Message-ID: <3EFDDFD9.3070905@paradyne.com> (raw)
In-Reply-To: <3EF5B5CE.6050103@paradyne.com>
I guess more the second.
I'm going to add some make targets to do the userspace stuff only.
Philip Pokorny wrote:
> I guess that depends on what the expected use of the mkpatch script is.
>
> Is the idea to inject a specific version of lm_sensors into a kernel
> tree for development and tweaking. Perhaps someone is playing with
> config file options, or other kernel patches and wants i2c/sensors
> available as modules in all the development work they do? (Alan Cox's
> -ac kernel trees, OS distro developers...)
>
> Or is it meant for people compiling a monolithic kernel and therefore
> need the i2c/sensors files to be in the kernel tree for linking into the
> monolithic kernel?
>
> In the first case, you're not going to run "make install" so you're
> going to have to provide the files in a different manner.
>
> In the second case, you're right. "make install" or something similar
> could just install in $(PREFIX)/include/linux...
>
> :v)
>
> Mark Studebaker wrote:
>
>> Shouldn't sensors.h (and the sensors userspace version of i2c-dev.h)
>> just get installed in /usr/local/include/linux
>> when you do a 'make install'?
>>
>> Philip Pokorny wrote:
>>
>>> When we make a patch, why not generate the sensors.h and then put the
>>> result in the patch for installation in include/linux/sensors.h or
>>> similar.
>>>
>>> If you're going to compile user space code against your patched kernel,
>>> you're going to need that header file and I would expect that the
>>> user-space command line would need to specify:
>>> -I/lib/modules/$(uname -r)/build/include
>>> or it's equivalent...
>>>
>>> :v)
>>>
>>> Mark D. Studebaker wrote:
>>>
>>>> I think that sensors.h (which is autogenerated now) is now
>>>> userspace-only
>>>> (it isn't included by any chip driver). So I'll remove it from FILES
>>>> and
>>>> INCLUDES.
>>>>
>>>> Mark M. Hoffman wrote:
>>>>
>>>>
>>>>> * Mark M. Hoffman <mhoffman@lightlink.com> [2003-06-22 11:17:05
>>>>> -0400]:
>>>>>
>>>>>
>>>>>> * Mark D. Studebaker <mds@paradyne.com> [2003-06-22 09:57:34 -0400]:
>>>>>>
>>>>>>
>>>>>>> I got mkpatch working on both i2c and sensors,
>>>>>>> both configuring as modules and compiling-in.
>>>>>>> Please test.
>>>>>>>
>>>>>>> A few hints:
>>>>>>>
>>>>>>> - Follow steps in order: generate and apply i2c patch; then generate
>>>>>>> and apply sensors patch.
>>>>>>
>>>>>>
>>>>>>
>>>>>> I2C mkpatch works and applies cleanly to 2.4.9.
>>>>>>
>>>>>> Then lm_sensors mkpatch says this:
>>>>>>
>>>>>> Can't open './kernel/include/sensors.h' at mkpatch/mkpatch.pl line
>>>>>> 1432.
>>>>>>
>>>>>> Is that file generated on the fly now?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Hmmm, it's in there... but 'make clean' deleted it. Is that the right
>>>>> thing
>>>>> for 'make clean' to do?
>>>>>
>>>>> Regards,
>>>>>
>>>>
>>> --
>>> Philip Pokorny, Director of Engineering
>>> Tel: 415-358-2635 Fax: 415-358-2646 Toll Free: 888-PENGUIN
>>> PENGUIN COMPUTING, INC.
>>> www.penguincomputing.com
>>
>>
>>
>
>
>
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:24 mkpatch works Mark D. Studebaker
2005-05-19 6:24 ` Mark M. Hoffman
2005-05-19 6:24 ` Philip Pokorny
2005-05-19 6:24 ` Mark M. Hoffman
2005-05-19 6:24 ` Philip Pokorny
2005-05-19 6:24 ` Mark D. Studebaker
2005-05-19 6:24 ` Mark Studebaker
2005-05-19 6:24 ` Mark M. Hoffman
2005-05-19 6:24 ` Mark D. Studebaker [this message]
2005-05-19 6:24 ` Mark M. Hoffman
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Mark M. Hoffman
2005-05-19 6:24 ` Mark D. Studebaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EFDDFD9.3070905@paradyne.com \
--to=mds@paradyne.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.