From: Patrick McHardy <kaber@trash.net>
To: "Filip Sneppe (Cronos)" <filip.sneppe@cronos.be>
Cc: netfilter@interlinx.bc.ca, netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 2.4/2.5]
Date: Sun, 29 Jun 2003 22:56:07 +0200 [thread overview]
Message-ID: <3EFF5267.2080808@trash.net> (raw)
In-Reply-To: <1056913883.1068.70.camel@exile>
Hi Filip,
you should remove the memsets, they are currently beeing removed from the
others helpers.
Best regards,
Patrick
Filip Sneppe (Cronos) wrote:
>- if (ret) {
>- printk("ip_ct_amanda: ERROR registering helper\n");
>- fini();
>- return -EBUSY;
>+ for(i = 0; (i < MAX_PORTS) && ports[i]; i++) {
>+ memset(&amanda_helper[i], 0, sizeof(struct ip_conntrack_helper));
>+ amanda_helper[i].tuple.src.u.udp.port = htons(ports[i]);
>+ amanda_helper[i].tuple.dst.protonum = IPPROTO_UDP;
>
>
>
prev parent reply other threads:[~2003-06-29 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-29 19:11 [PATCH 2.4/2.5] Filip Sneppe (Cronos)
2003-06-29 19:37 ` Brian J. Murrell
2003-06-29 20:20 ` Filip Sneppe (Cronos)
2003-06-29 20:31 ` Brian J. Murrell
2003-06-30 12:05 ` Harald Welte
2003-06-30 12:42 ` Brian J. Murrell
2003-06-29 20:56 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EFF5267.2080808@trash.net \
--to=kaber@trash.net \
--cc=filip.sneppe@cronos.be \
--cc=netfilter-devel@lists.netfilter.org \
--cc=netfilter@interlinx.bc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.