All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Dunkel <harri@synopsys.COM>
To: linux-kernel@vger.kernel.org
Cc: James Simmons <jsimmons@infradead.org>,
	Petr Vandrovec <VANDROVE@vc.cvut.cz>,
	Flameeyes <daps_mls@libero.it>
Subject: Re: 2.5.71, fbconsole: No boot logo?
Date: Sat, 05 Jul 2003 17:14:44 +0200	[thread overview]
Message-ID: <3F06EB64.4090808@Synopsys.COM> (raw)
In-Reply-To: <Pine.LNX.4.44.0306162133520.12997-100000@phoenix.infradead.org>

Hi folks,

James Simmons wrote:
>>It is probably some uninitialized value or something like that.
>>
>>At work I have no logo, while at home I have logo (both 2.5.71 from
>>yesterday), both with matroxfb... Only significant difference I know
>>is that at home I have UP kernel, while at work I have SMP. But it should 
>>not matter, yes?
> 
> 
> Its a bug in cfbimgblt.c. In cfb_imageblit you have a test 
> 
> } else if (image->depth == bpp)
> 
> Its should be 
> 
> } else if (image->depth <= bpp)
> 
> instead. At present the logo will only show up when the framebuffer depth 
> matches the image's depth. cfb_imageblit supports displaying images of 
> equal or lesser depths than the framebuffer.
> 

Would it be possible to include this change in the official
source tree?


Regards

Harri


  parent reply	other threads:[~2003-07-05 15:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-16 19:35 2.5.71, fbconsole: No boot logo? Petr Vandrovec
2003-06-16 20:36 ` James Simmons
2003-06-17 18:06   ` Harald Dunkel
2003-07-05 15:14   ` Harald Dunkel [this message]
2003-07-05 15:53     ` Alex Goddard
2003-06-17 16:58 ` Nicholas Wourms
2003-06-17 17:27   ` James Simmons
  -- strict thread matches above, loose matches on Subject: below --
2003-06-16 17:41 Harald Dunkel
2003-06-16 18:39 ` ismail (cartman) donmez
2003-06-16 18:53   ` Flameeyes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F06EB64.4090808@Synopsys.COM \
    --to=harri@synopsys.com \
    --cc=VANDROVE@vc.cvut.cz \
    --cc=daps_mls@libero.it \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.