From: Jeff Garzik <jgarzik@pobox.com>
To: Paul Clements <Paul.Clements@SteelEye.com>
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHES 2.5.74-mm2] misc. nbd cleanups/fixes
Date: Sun, 06 Jul 2003 16:33:33 -0400 [thread overview]
Message-ID: <3F08879D.4070300@pobox.com> (raw)
In-Reply-To: <3F088277.3EB39CE2@SteelEye.com>
Paul Clements wrote:
> The two attached patches are:
>
> 1) nbd-remove_open_release.diff - remove the unneeded nbd_open and
> nbd_release functions
Please remove the unneeded ->refcnt member as well.
> 2) nbd-block_layer_compat.diff - ensure that nbd and the block layer
> agree about device block sizes and total device sizes
Use set_blocksize, please.
Also, please split up your patches further. The Linux (Linus?) standard
is one patch per email... Also, attachments are discouraged, though not
a "no no" because of various broken corporate email systems...
Jeff
next prev parent reply other threads:[~2003-07-06 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-06 20:11 [PATCHES 2.5.74-mm2] misc. nbd cleanups/fixes Paul Clements
2003-07-06 20:33 ` Jeff Garzik [this message]
2003-07-06 21:10 ` Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F08879D.4070300@pobox.com \
--to=jgarzik@pobox.com \
--cc=Paul.Clements@SteelEye.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.