All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Paul.Clements@steeleye.com
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org,
	viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH 2.5.74-mm2] nbd: make nbd and block layer agree about device and  block sizes
Date: Sun, 06 Jul 2003 18:02:28 -0400	[thread overview]
Message-ID: <3F089C74.6070005@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10307061750040.764-100000@clements.sc.steeleye.com>

Paul Clements wrote:
> On Sun, 6 Jul 2003, Jeff Garzik wrote:
>>Also, I wonder if you found a bug/oversight in set_blocksize -- it sets 
>>bd_inode->i_blkbits but not bd_inode->i_size.  I think it should set 
>>i_size also.  Maybe Andrew or Al can confirm/refute this assertion.
> 
> 
> OK, I'll wait for a response on this, and then redo the patch as appropriate...


No, nevermind.  What I was said dumb ;-)

The inode's size should not be the block size.

	Jeff




  reply	other threads:[~2003-07-06 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-06 21:15 [PATCH 2.5.74-mm2] nbd: remove unneeded nbd_open/nbd_release and refcnt Paul Clements
2003-07-06 21:20 ` [PATCH 2.5.74-mm2] nbd: make nbd and block layer agree about device and block sizes Paul Clements
2003-07-06 21:38   ` Jeff Garzik
2003-07-06 21:55     ` Paul Clements
2003-07-06 22:02       ` Jeff Garzik [this message]
2003-07-06 22:03     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F089C74.6070005@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=Paul.Clements@steeleye.com \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.