From: Matthew Dobson <colpatch@us.ibm.com>
To: Trivial Patch Monkey <trivial@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: [trivial][patch] no more warnings! [1/3] zap_low_mappings
Date: Thu, 10 Jul 2003 16:43:54 -0700 [thread overview]
Message-ID: <3F0DFA3A.10200@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
acpi_restore_state_mem() in arch/i386/kernel/acpi/sleep.c uses
zap_low_mappings() and isn't SMP-specific. zap_low_mappings() is
extern'd in include/asm-i386/smp.h, but wrapped in CONFIG_SMP ifdefs.
This should be exported for non-CONFIG_SMP as well. This patch does that.
Cheers!
-Matt
[-- Attachment #2: zap_low_mappings-warning.patch --]
[-- Type: text/plain, Size: 1164 bytes --]
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.5.74-vanilla/include/asm-i386/smp.h linux-2.5.74-warnings/include/asm-i386/smp.h
--- linux-2.5.74-vanilla/include/asm-i386/smp.h Thu Jul 10 11:49:47 2003
+++ linux-2.5.74-warnings/include/asm-i386/smp.h Thu Jul 10 14:37:35 2003
@@ -8,10 +8,8 @@
#include <linux/config.h>
#include <linux/kernel.h>
#include <linux/threads.h>
-#endif
#ifdef CONFIG_X86_LOCAL_APIC
-#ifndef __ASSEMBLY__
#include <asm/fixmap.h>
#include <asm/bitops.h>
#include <asm/mpspec.h>
@@ -20,7 +18,9 @@
#endif
#include <asm/apic.h>
#endif
-#endif
+
+extern void zap_low_mappings (void);
+#endif /* !__ASSEMBLY__ */
#define BAD_APICID 0xFFu
#ifdef CONFIG_SMP
@@ -43,7 +43,6 @@ extern void smp_message_irq(int cpl, voi
extern void smp_send_reschedule(int cpu);
extern void smp_invalidate_rcv(void); /* Process an NMI */
extern void (*mtrr_hook) (void);
-extern void zap_low_mappings (void);
#define MAX_APICID 256
@@ -106,8 +105,6 @@ static __inline int logical_smp_processo
#endif
#endif /* !__ASSEMBLY__ */
-
#define NO_PROC_ID 0xFF /* No processor magic marker */
-
-#endif
+#endif /* CONFIG_SMP */
#endif
reply other threads:[~2003-07-10 23:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0DFA3A.10200@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.