From: Miguel Sousa Filipe <m3thos@netcabo.pt>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test1 doesn't compile on PPC iBook2.2
Date: Thu, 17 Jul 2003 01:57:21 +0100 [thread overview]
Message-ID: <3F15F471.3000004@netcabo.pt> (raw)
In-Reply-To: <3F15EEB7.2060008@netcabo.pt>
Miguel Sousa Filipe wrote:
> Mikael Pettersson wrote:
>
>> On Wed, 16 Jul 2003 22:14:40 +0100, Miguel Sousa Filipe wrote:
>>
>>> CC arch/ppc/kernel/time.o
>>> arch/ppc/kernel/time.c: In function `do_settimeofday':
>>> arch/ppc/kernel/time.c:247: conflicting types for `new_nsec'
>>> arch/ppc/kernel/time.c:245: previous declaration of `new_nsec'
>>> arch/ppc/kernel/time.c:247: conflicting types for `new_sec'
>>> arch/ppc/kernel/time.c:244: previous declaration of `new_sec'
>>> make[1]: *** [arch/ppc/kernel/time.o] Error 1
>>> make: *** [arch/ppc/kernel] Error 2
>>
>>
>>
>> Apply the following patch:
>>
>> --- linux-2.6.0-test1/arch/ppc/kernel/time.c.~1~ 2003-07-14
>> 13:17:24.000000000 +0200
>> +++ linux-2.6.0-test1/arch/ppc/kernel/time.c 2003-07-14
>> 19:06:58.000000000 +0200
>> @@ -244,7 +244,7 @@
>> time_t wtm_sec, new_sec = tv->tv_sec;
>> long wtm_nsec, new_nsec = tv->tv_nsec;
>> unsigned long flags;
>> - int tb_delta, new_nsec, new_sec;
>> + int tb_delta;
>>
>> if ((unsigned long)tv->tv_nsec >= NSEC_PER_SEC)
>> return -EINVAL;
>>
>
> Done, now it fails in arch/ppc/platforms/pmac_cpufreq.c,
>
> here is the error:
>
> CC arch/ppc/platforms/pmac_nvram.o
> CC arch/ppc/platforms/pmac_cpufreq.o
> arch/ppc/platforms/pmac_cpufreq.c: In function `do_set_cpu_speed':
> arch/ppc/platforms/pmac_cpufreq.c:179: `CPUFREQ_ALL_CPUS' undeclared
> (first use in this function)
> arch/ppc/platforms/pmac_cpufreq.c:179: (Each undeclared identifier is
> reported only once
> arch/ppc/platforms/pmac_cpufreq.c:179: for each function it appears in.)
> make[1]: *** [arch/ppc/platforms/pmac_cpufreq.o] Error 1
> make: *** [arch/ppc/platforms] Error 2
>
>
Extra information,
newton linux-2.6.0-test1 # find ./ -type f -exec grep -H CPUFREQ_ALL_CPUS {} \;
./arch/ppc/platforms/pmac_cpufreq.c: freqs.cpu = CPUFREQ_ALL_CPUS;
./drivers/cpufreq/proc_intf.c:#define CPUFREQ_ALL_CPUS ((NR_CPUS))
I just added
#define CPUFREQ_ALL_CPUS ((NR_CPUS))
to pmac_cpufreq.c, line 22 (before the UNDEF)
it compiled pmac_cpufreq.o
Is this the propper fix?
Miguel Filipe
next prev parent reply other threads:[~2003-07-17 0:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-17 0:15 2.6.0-test1 doesn't compile on PPC iBook2.2 Mikael Pettersson
2003-07-17 0:32 ` Miguel Sousa Filipe
2003-07-17 0:57 ` Miguel Sousa Filipe [this message]
2003-07-17 1:28 ` Paul Mundt
2003-07-17 1:48 ` Miguel Sousa Filipe
2003-07-17 1:55 ` Paul Mundt
-- strict thread matches above, loose matches on Subject: below --
2003-07-16 21:14 Miguel Sousa Filipe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F15F471.3000004@netcabo.pt \
--to=m3thos@netcabo.pt \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.