From: Bernardo Innocenti <bernie@develer.com>
To: Andrew Morton <akpm@osdl.org>
Cc: george anzinger <george@mvista.com>,
linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk,
torvalds@osdl.org
Subject: Re: do_div64 generic
Date: Fri, 18 Jul 2003 06:14:53 +0200 [thread overview]
Message-ID: <3F17743D.2090006@develer.com> (raw)
In-Reply-To: <20030717201905.6ab4a90f.akpm@osdl.org>
Andrew Morton wrote:
>>>Ths one's OK by me. Let's just fix the bug with minimum risk and churn.
>>
>> Uh, bug? I was not aware that there was a bug. As far as I know,
>> nothing is broken.
>
> wtf? Then why are people running around brandishing big scary patches
> at me?
ROTFL! :-)
I've been asked by George to add generic support for the existing
div_long_long_rem() inline function.
The patch might be big, but not that much scary... I'm just replacing
two local redefinitions of the macro with a single inline in
asm-generic/div64.h. It's more a cleanup than a bug fix.
The patch also takes care of the few archs that wrote their own
optimized versions of do_div(). For those, I've implemented
div_long_long_rem() in terms of do_div() because it might still
be better than the generic version. I've left a FIXME there to
let the arch maintainers know that these could be better optimized.
And, as a special bonus, the patch also adds missing parentheses
around do_div() arguments in asm-arm/div64.h. This is the only real
bug being fixed.
next prev parent reply other threads:[~2003-07-18 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3F1360F4.2040602@mvista.com>
2003-07-15 5:17 ` do_div64 generic Bernardo Innocenti
2003-07-15 5:38 ` Andrew Morton
2003-07-15 6:23 ` Bernardo Innocenti
2003-07-15 6:30 ` Andrew Morton
2003-07-15 21:52 ` george anzinger
2003-07-15 22:06 ` Andrew Morton
2003-07-16 0:07 ` george anzinger
2003-07-16 18:33 ` Bernardo Innocenti
2003-07-17 21:10 ` Bernardo Innocenti
2003-07-17 21:16 ` Andrew Morton
2003-07-17 22:43 ` Bernardo Innocenti
2003-07-17 23:10 ` george anzinger
2003-07-18 3:19 ` Andrew Morton
2003-07-18 4:14 ` Bernardo Innocenti [this message]
2003-07-17 23:09 ` george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F17743D.2090006@develer.com \
--to=bernie@develer.com \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.