Re: BUG in reiserfs_write_full_page().

[Michael Gaughen <mgaughen@polyserve.com>]

Chris Mason wrote:

>On Fri, 2003-07-18 at 09:45, Nikita Danilov wrote:
>  
>
>> > 
>> > But, we shouldn't have to.  Other parts of the OS should be protecting
>> > us from a writepage being called at this time, which is why the bug is
>> > there.  Someone did a non GFP_NOFS allocation with a transaction
>>
>>__bread()->__getblk()->__find_get_block()->find_get_page() allocates
>>page with bdev->bd_inode->i_mapping->gfp_flags, which is GFP_USER, that
>>includes GFP_FS.
>>    
>>
>
>You're in 2.5 land ;-)  There seem to be a few problems there, I've got
>an oops in find_inode and a deadlock under load, but I still need to
>read the (huge) sysrq-t to figure things out.
>

But, in 2.4, the page fault handling code also gets the gfp_mask from 
the inode's
address_space gfp_mask (in ->page_cache_read()->page_cache_alloc()).  It 
looks
like clean_inode() sets the gfp_mask to GFP_HIGHUSER, which also includes
GFP_FS, and unless I am missing something, I don't see that GFP_FS is ever
cleared in this case.

-Mike