Return-Path: Delivered-To: garzik@gtf.org Received: from orb.pobox.com (orb.pobox.com [216.65.124.72]) by havoc.gtf.org (Postfix) with ESMTP id 7E9F1663B for ; Sat, 19 Jul 2003 22:57:55 -0400 (EDT) Received: from orb.pobox.com (localhost [127.0.0.1]) by orb.pobox.com (Postfix) with ESMTP id C895C1562EC for ; Sat, 19 Jul 2003 22:57:54 -0400 (EDT) Delivered-To: jgarzik@pobox.com Received: from smtp.mandrake.com (smtp.mandrake.com [63.209.80.248]) by orb.pobox.com (Postfix) with ESMTP id BE51915620B for ; Sat, 19 Jul 2003 22:57:54 -0400 (EDT) Received: from oss.sgi.com (oss.sgi.com [192.48.159.27]) by smtp.mandrake.com (Postfix) with ESMTP id 2EB3A83C0E for ; Sat, 19 Jul 2003 18:10:30 -0700 (PDT) Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.12.9/8.12.9) with ESMTP id h6K2unFl011061; Sat, 19 Jul 2003 19:56:49 -0700 Received: with ECARTIS (v1.0.0; list netdev); Sat, 19 Jul 2003 19:55:41 -0700 (PDT) Received: from rei.rakuen (dclient217-162-65-211.hispeed.ch [217.162.65.211]) by oss.sgi.com (8.12.9/8.12.9) with SMTP id h6K2taFl010762 for ; Sat, 19 Jul 2003 19:55:37 -0700 Received: by reeler.org id 19e4MD-0007Pb-00 for ; Sun, 20 Jul 2003 04:55:29 +0200 Date: Sun, 20 Jul 2003 04:55:29 +0200 From: Thomas Graf To: netdev@oss.sgi.com Subject: [PATCH] missing __KERNEL__ ifdef in include/linux/device.h Message-ID: <20030720025528.GA30577@rei.rakuen> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Encryption: "Encrypted with ROT13 using key 42" X-archive-position: 4180 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-To: netdev-bounce@oss.sgi.com X-original-sender: tgraf@suug.ch Precedence: bulk X-list: netdev X-Spam-Status: No, hits=-6.0 required=6.0 tests=AWL,BAYES_01,PATCH_UNIFIED_DIFF version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Hello device.h should be protected with __KERNEL__ because it uses __KERNEL__ protected structures. Userspace applications including if_arp.h such as iproute2 will fail because it finally includes device.h as well. - thomas Index: include/linux/device.h =================================================================== RCS file: /cvs/tgr/linux-25/include/linux/device.h,v retrieving revision 1.1.1.2 diff -u -r1.1.1.2 device.h --- include/linux/device.h 10 Jul 2003 22:58:31 -0000 1.1.1.2 +++ include/linux/device.h 20 Jul 2003 02:49:12 -0000 @@ -8,7 +8,7 @@ * See Documentation/driver-model/ for more information. */ -#ifndef _DEVICE_H_ +#if defined __KERNEL__ && !defined _DEVICE_H_ #define _DEVICE_H_ #include