From: Stephane Ouellette <ouellettes@videotron.ca>
To: Harald Welte <laforge@gnumonks.org>
Cc: netfilter-devel@lists.netfilter.org
Subject: [PATCH][TRIVIAL] Unused variable in libipt_LOG.c and libip6t_LOG.c
Date: Sun, 03 Aug 2003 20:15:52 -0400 [thread overview]
Message-ID: <3F2DA5B8.8040109@videotron.ca> (raw)
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
Harald,
the following two patches remove an unused variable in save() and
convert all structure initialization to C99.
Regards,
Stephane Ouellette
[-- Attachment #2: libipt_LOG.c.patch --]
[-- Type: text/plain, Size: 2593 bytes --]
--- netfilter/userspace/extensions/libipt_LOG.c Mon Jul 14 16:01:29 2003
+++ netfilter.fixed/userspace/extensions/libipt_LOG.c Sun Aug 3 19:54:50 2003
@@ -26,12 +26,12 @@
}
static struct option opts[] = {
- { "log-level", 1, 0, '!' },
- { "log-prefix", 1, 0, '#' },
- { "log-tcp-sequence", 0, 0, '1' },
- { "log-tcp-options", 0, 0, '2' },
- { "log-ip-options", 0, 0, '3' },
- { 0 }
+ { .name = "log-level", .has_arg = 1, .flag = 0, .val = '!' },
+ { .name = "log-prefix", .has_arg = 1, .flag = 0, .val = '#' },
+ { .name = "log-tcp-sequence", .has_arg = 0, .flag = 0, .val = '1' },
+ { .name = "log-tcp-options", .has_arg = 0, .flag = 0, .val = '2' },
+ { .name = "log-ip-options", .has_arg = 0, .flag = 0, .val = '3' },
+ { .name = 0 }
};
/* Initialize the target. */
@@ -52,15 +52,15 @@
};
static struct ipt_log_names ipt_log_names[]
-= { { "alert", LOG_ALERT },
- { "crit", LOG_CRIT },
- { "debug", LOG_DEBUG },
- { "emerg", LOG_EMERG },
- { "error", LOG_ERR }, /* DEPRECATED */
- { "info", LOG_INFO },
- { "notice", LOG_NOTICE },
- { "panic", LOG_EMERG }, /* DEPRECATED */
- { "warning", LOG_WARNING }
+= { { .name = "alert", .level = LOG_ALERT },
+ { .name = "crit", .level = LOG_CRIT },
+ { .name = "debug", .level = LOG_DEBUG },
+ { .name = "emerg", .level = LOG_EMERG },
+ { .name = "error", .level = LOG_ERR }, /* DEPRECATED */
+ { .name = "info", .level = LOG_INFO },
+ { .name = "notice", .level = LOG_NOTICE },
+ { .name = "panic", .level = LOG_EMERG }, /* DEPRECATED */
+ { .name = "warning", .level = LOG_WARNING }
};
static u_int8_t
@@ -225,7 +225,6 @@
{
const struct ipt_log_info *loginfo
= (const struct ipt_log_info *)target->data;
- unsigned int i = 0;
if (strcmp(loginfo->prefix, "") != 0)
printf("--log-prefix \"%s\" ", loginfo->prefix);
@@ -243,18 +242,18 @@
static
struct iptables_target log
-= { NULL,
- "LOG",
- IPTABLES_VERSION,
- IPT_ALIGN(sizeof(struct ipt_log_info)),
- IPT_ALIGN(sizeof(struct ipt_log_info)),
- &help,
- &init,
- &parse,
- &final_check,
- &print,
- &save,
- opts
+= {
+ .name = "LOG",
+ .version = IPTABLES_VERSION,
+ .size = IPT_ALIGN(sizeof(struct ipt_log_info)),
+ .userspacesize = IPT_ALIGN(sizeof(struct ipt_log_info)),
+ .help = &help,
+ .init = &init,
+ .parse = &parse,
+ .final_check = &final_check,
+ .print = &print,
+ .save = &save,
+ .extra_opts = opts
};
void _init(void)
[-- Attachment #3: libip6t_LOG.c.patch --]
[-- Type: text/plain, Size: 2608 bytes --]
--- netfilter/userspace/extensions/libip6t_LOG.c Mon Jul 14 16:01:29 2003
+++ netfilter.fixed/userspace/extensions/libip6t_LOG.c Sun Aug 3 20:02:57 2003
@@ -26,12 +26,12 @@
}
static struct option opts[] = {
- { "log-level", 1, 0, '!' },
- { "log-prefix", 1, 0, '#' },
- { "log-tcp-sequence", 0, 0, '1' },
- { "log-tcp-options", 0, 0, '2' },
- { "log-ip-options", 0, 0, '3' },
- { 0 }
+ { .name = "log-level", .has_arg = 1, .flag = 0, .val = '!' },
+ { .name = "log-prefix", .has_arg = 1, .flag = 0, .val = '#' },
+ { .name = "log-tcp-sequence", .has_arg = 0, .flag = 0, .val = '1' },
+ { .name = "log-tcp-options", .has_arg = 0, .flag = 0, .val = '2' },
+ { .name = "log-ip-options", .has_arg = 0, .flag = 0, .val = '3' },
+ { .name = 0 }
};
/* Initialize the target. */
@@ -52,15 +52,15 @@
};
static struct ip6t_log_names ip6t_log_names[]
-= { { "alert", LOG_ALERT },
- { "crit", LOG_CRIT },
- { "debug", LOG_DEBUG },
- { "emerg", LOG_EMERG },
- { "error", LOG_ERR }, /* DEPRECATED */
- { "info", LOG_INFO },
- { "notice", LOG_NOTICE },
- { "panic", LOG_EMERG }, /* DEPRECATED */
- { "warning", LOG_WARNING }
+= { { .name = "alert", .level = LOG_ALERT },
+ { .name = "crit", .level = LOG_CRIT },
+ { .name = "debug", .level = LOG_DEBUG },
+ { .name = "emerg", .level = LOG_EMERG },
+ { .name = "error", .level = LOG_ERR }, /* DEPRECATED */
+ { .name = "info", .level = LOG_INFO },
+ { .name = "notice", .level = LOG_NOTICE },
+ { .name = "panic", .level = LOG_EMERG }, /* DEPRECATED */
+ { .name = "warning", .level = LOG_WARNING }
};
static u_int8_t
@@ -225,7 +225,6 @@
{
const struct ip6t_log_info *loginfo
= (const struct ip6t_log_info *)target->data;
- unsigned int i = 0;
if (strcmp(loginfo->prefix, "") != 0)
printf("--log-prefix \"%s\" ", loginfo->prefix);
@@ -243,18 +242,18 @@
static
struct ip6tables_target log
-= { NULL,
- "LOG",
- IPTABLES_VERSION,
- IP6T_ALIGN(sizeof(struct ip6t_log_info)),
- IP6T_ALIGN(sizeof(struct ip6t_log_info)),
- &help,
- &init,
- &parse,
- &final_check,
- &print,
- &save,
- opts
+= {
+ .name = "LOG",
+ .version = IPTABLES_VERSION,
+ .size = IP6T_ALIGN(sizeof(struct ip6t_log_info)),
+ .userspacesize = IP6T_ALIGN(sizeof(struct ip6t_log_info)),
+ .help = &help,
+ .init = &init,
+ .parse = &parse,
+ .final_check = &final_check,
+ .print = &print,
+ .save = &save,
+ .extra_opts = opts
};
void _init(void)
next reply other threads:[~2003-08-04 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-04 0:15 Stephane Ouellette [this message]
2003-08-11 19:54 ` [PATCH][TRIVIAL] Unused variable in libipt_LOG.c and libip6t_LOG.c Harald Welte
-- strict thread matches above, loose matches on Subject: below --
2003-08-11 13:42 Stephane Ouellette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F2DA5B8.8040109@videotron.ca \
--to=ouellettes@videotron.ca \
--cc=laforge@gnumonks.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.